Skip to content

ENH: Change python version to 3.6.12#5161

Closed
BishopWolf wants to merge 1 commit intoSlicer:masterfrom
BishopWolf:master
Closed

ENH: Change python version to 3.6.12#5161
BishopWolf wants to merge 1 commit intoSlicer:masterfrom
BishopWolf:master

Conversation

@BishopWolf
Copy link
Copy Markdown
Contributor

Current python version 3.6.7 has not received any update since October 20,2018. All bug fixes for branch 3.6 are integrated in version 3.6.12 which is still receiving corrections (the last one from August 17, 2020)

Some bugs from version 3.6.7 are rising and exposed here

@BishopWolf BishopWolf changed the title Change python version to 3.6.12 [WIP] Change python version to 3.6.12 - do not merge yet! Sep 2, 2020
@jcfr
Copy link
Copy Markdown
Member

jcfr commented Sep 2, 2020

Thanks for the contribution 🙏

Would be great if you could:

@BishopWolf
Copy link
Copy Markdown
Contributor Author

What is the requirement for the commit message? I have tried like 5 different approaches and neither pass the check

@jcfr
Copy link
Copy Markdown
Member

jcfr commented Sep 2, 2020

What is the requirement for the commit message?

See https://slicer.readthedocs.io/en/latest/developer_guide/contributing.html#how-to-write-commit-messages

@BishopWolf
Copy link
Copy Markdown
Contributor Author

I have added support for python 3.6.8 to 3.6.12 in the PR

@BishopWolf BishopWolf changed the title [WIP] Change python version to 3.6.12 - do not merge yet! ENH: Change python version to 3.6.12 Sep 3, 2020
@BishopWolf
Copy link
Copy Markdown
Contributor Author

Tested in Docker and Ubuntu. It runs smoothly!

@jcfr
Copy link
Copy Markdown
Member

jcfr commented Sep 3, 2020

Thanks for testing on Ubuntu and submitting a PR on the upstream project.

After updating the CI, it turns out that windows build is failing:
https://open.cdash.org/index.php?project=CPython&date=2020-09-03&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=3.6.12-VS

error C2065: 'PY3_DLLNAME': undeclared identifier

It may be worth looking if some changes from python-cmake-buildsystem/python-cmake-buildsystem#267 are relevant.

@BishopWolf
Copy link
Copy Markdown
Contributor Author

BishopWolf commented Sep 3, 2020

@jcfr Unfortunately I am very bad at windows debugging. May somebody else help on this?

This PR just moves from python 3.6.7 to python 3.6.12. In theory there shall not be any change in functionality inside the same branch

I have added the missing line in the PR

@BishopWolf
Copy link
Copy Markdown
Contributor Author

It seems that line solved the build errors! ;)

@lassoan
Copy link
Copy Markdown
Contributor

lassoan commented Nov 18, 2021

I'm closing this issue now, as Python-3.6 will reach end of life in about a month. We are trying to upgrade to Python-3.9 (#6026).

@lassoan lassoan closed this Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants