-
Notifications
You must be signed in to change notification settings - Fork 203
[IRN-6178] [BpkCardList] Enable Physical Scroll For Row #3974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex (rabisse)
wants to merge
9
commits into
main
Choose a base branch
from
IRN-6178_BpkCardList_EnablePhysicalScrollForRow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−12
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4381a0e
IRN-6178 BpkCardList Enable Physical Scroll For Row
rabisse cd69b3e
===
rabisse 1b8ee6f
Merge branch 'main' into IRN-6178_BpkCardList_EnablePhysicalScrollForRow
chiefkes 14d8e63
use existing stateScrollingLockRef
chiefkes 77ad06c
original useEffect deps
chiefkes 7ed22a1
undo
chiefkes e7f9cf4
Merge branch 'IRN-6178_BpkCardList_EnablePhysicalScrollForRow' of git…
chiefkes 3bf086f
handle changes to initialShownCards as before
chiefkes a35f025
Merge branch 'main' into IRN-6178_BpkCardList_EnablePhysicalScrollForRow
jimmycook File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this necessary Alex (@rabisse) ?