Skip to content

Conversation

@senzg
Copy link
Contributor

@senzg senzg commented Apr 14, 2025

We can customize the max width of the inner div as the example here:

ontréal-Trudeau International Airport Testing long text Testing

ariaLabel=Montréal-Trudeau International

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [Clover-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@senzg senzg added the minor Non breaking change label Apr 14, 2025
@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3800 to see this build running in a browser.

@skyscanner-backpack-bot
Copy link

skyscanner-backpack-bot bot commented Apr 14, 2025

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against c3f80e9

@skyscanner-backpack-bot
Copy link

Visit https://backpack.github.io/storybook-prs/3800 to see this build running in a browser.

@senzg senzg changed the title [Clover GF][BpkTooltip]The max-width of BpkTooltip can be Customized [WIP][Clover GF][BpkTooltip]The max-width of BpkTooltip can be Customized Apr 14, 2025
@olliecurtis
Copy link
Member

Here I would expect the content that is passed into the BpkTooltip to control the width of the tooltip as the component is just a dumb container that should react to the content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Non breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants