-
Notifications
You must be signed in to change notification settings - Fork 34
[DON-2457] Fix bottom sheet height to use wrapContentSize for better … #2551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…scaling with large font sizes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the modal bottom sheet header height to be content-based instead of fixed, improving support for text scaling and accessibility. The change allows the header to adapt to its content size rather than being constrained to a fixed height.
- Replaced fixed height constraint with
wrapContentSize()to allow header to size based on content - Updated imports to reflect the modifier change
.../main/kotlin/net/skyscanner/backpack/compose/bottomsheet/internal/BpkModalBottomSheetImpl.kt
Outdated
Show resolved
Hide resolved
Generated by 🚫 Danger Kotlin against 60246a6 |
Generated by 🚫 Danger Kotlin against 705ee7c |
Generated by 🚫 Danger Kotlin against 640012b |
Generated by 🚫 Danger Kotlin against 25d0cb1 |
This pull request makes a small change to the layout of the modal bottom sheet header in the Compose implementation. The main update replaces a fixed height with a more flexible sizing approach for the header component.
Modifier.height(BpkSpacing.Lg)withModifier.wrapContentSize()for the modal bottom sheet header, allowing the header to size itself based on its content instead of a fixed height.heightand addedwrapContentSizeto the imports inBpkModalBottomSheetImpl.kt.Remember to include the following changes:
README.mdIf you are curious about how we review, please read through the code review guidelines