Skip to content

Conversation

@aricloverEXTRA
Copy link

@aricloverEXTRA aricloverEXTRA commented Nov 10, 2025

Adds in Dark Mode textures for the mod Skyblocker (1.21.9/1.21.10 & 1.21.8-backport).

This pull request introduces Dark Mode GUI textures for Skyblocker,

This PR is in draft for now, since I haven’t added the code to toggle these Dark Mode assets yet. (edit: couldn’t make it toggleable, found out it used vanilla Minecraft textures in parts of the Skyblocker mod)

These assets are also from the following:

  1. https://github.com/aricloverEXTRA/Default-Dark-Mode-Expansion/tree/1.21/assets/skyblocker
  2. Add support for Skyblocker mod nebuIr/Default-Dark-Mode#201

Dark Mode GUI example

2c959826ed1e0f8cfff3cfdbb1102c06e163b4f2

@LifeIsAParadox LifeIsAParadox added the wip This PR is a work in progress label Nov 10, 2025
@aricloverEXTRA
Copy link
Author

aricloverEXTRA commented Nov 12, 2025

2025-11-11_22 19 36_edited

Pull Request Update: it's almost complete, it's added as a built-in resource pack for Skyblocker 1.21.8 & 1.21.9/.10.
All I need to do is add the important textures into it! (2025-11-13: Finished, feel free to change anything in the pr.)

@aricloverEXTRA aricloverEXTRA marked this pull request as ready for review November 14, 2025 01:08
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels Nov 14, 2025
@viciscat
Copy link
Collaborator

Those are pretty nice. I'm not sure if we want to add this since https://modrinth.com/resourcepack/skyblock-dark-ui exists and this affects vanilla assets unrelated to skyblocker (like the hotbar). Thoughts from the other devs?

@aricloverEXTRA
Copy link
Author

Those are pretty nice. I'm not sure if we want to add this since https://modrinth.com/resourcepack/skyblock-dark-ui exists and this affects vanilla assets unrelated to skyblocker (like the hotbar). Thoughts from the other devs?

There was a Skyblocker maintainer named kevinthegreat1 that said it was a nice addition. The comment can be found here. nebuIr/Default-Dark-Mode#201 (comment)

But it’s up to y’all to determine if it should be merged or not. lmk if something happens!

Note: I decided to remove these for the Skyblocker dark mode gui for obvious reasons.
@kevinthegreat1
Copy link
Collaborator

I didn't know https://modrinth.com/resourcepack/skyblock-dark-ui existed. I think this would make more sense there or just added here https://github.com/aricloverEXTRA/Default-Dark-Mode-Expansion. Since these two exist I don't think we need to add it into skyblocker.

@aricloverEXTRA
Copy link
Author

aricloverEXTRA commented Nov 20, 2025

Yeah, guessing this pull request will be closed now, it was an alright addition but with Skyblocker Dark UI & Default Dark Mode: Expansion having dark mode versions, it does make the pull request useless. Have a good day devs.

@LifeIsAParadox LifeIsAParadox removed the reviews needed This PR needs reviews label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants