Skip to content

Conversation

@roxblnfk
Copy link
Contributor

simpleTest 1.1 added into composer.json

Old simpleTest was not deleted (for compatibility tests with php <5.4)

The results of running tests without plugins on different php versions below:
tests

Just run testunit/index.php on php 5 or php 7

Not tested on php <5.3

@roxblnfk roxblnfk mentioned this pull request Jan 20, 2018
@roxblnfk
Copy link
Contributor Author

roxblnfk commented Jan 20, 2018

Support for console mode
image

@simonschaufi
Copy link
Contributor

simonschaufi commented Jan 20, 2018

Please rebase your branch on master to avoid any merge commits and then force push your changes

@roxblnfk
Copy link
Contributor Author

Please rebase your branch on master to avoid any merge commits and then force push your changes

Can i do it from web interface?

@roxblnfk roxblnfk force-pushed the feature/simpleTest-update branch from 81396d2 to 7989a1a Compare January 20, 2018 11:41
@simonschaufi
Copy link
Contributor

Can i do it from web interface?

unfortunatelly not. If you collaborate with others on one pull request you should avoid that as it rewrites your commits. Do that only if you are the only one working on that pull request. Thats why github doesn't support that on the platform.

@roxblnfk roxblnfk force-pushed the feature/simpleTest-update branch from 7989a1a to 250a9ff Compare January 20, 2018 12:32
@roxblnfk roxblnfk force-pushed the feature/simpleTest-update branch from c1f3332 to f1d532d Compare February 1, 2018 10:34
@roxblnfk
Copy link
Contributor Author

roxblnfk commented Feb 1, 2018

composer test is now available

@Skrol29
Copy link
Owner

Skrol29 commented Feb 13, 2018

I suggest to simply delete the « testunit » and « benches » from this repository.
Those are quite old tools now.
What do you think ?

@simonschaufi
Copy link
Contributor

would you suggest switchting to phpunit? how easy is it to move to phpunit?

@roxblnfk
Copy link
Contributor Author

The modern PHPUnit requires php >= 7.1

In this Pull Request i suggest only that you update SimpleTest without losing compatibility
For php <5.4 will be used old SimpleTest
For php >=5.4 will be used last SimpleTest

When the project will depend on php >=7 then it will be meaningful to rewrite the tests for PHPUnit

@roxblnfk roxblnfk force-pushed the feature/simpleTest-update branch 2 times, most recently from 4156a02 to 1ce7e6b Compare April 29, 2019 08:27
`composer test` available
Added new test case
@roxblnfk
Copy link
Contributor Author

> composer update
> composer test

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants