Reformat code to PSR2 and use short array syntax #5
Conversation
simonschaufi
force-pushed
the
reformat-code
branch
from
06cedf8 to
757a271
Compare
|
Square brackets require a php version >=5.4 |
|
Yes I know but these old php versions are not supported anymore. |
simonschaufi
force-pushed
the
reformat-code
branch
from
757a271 to
004de82
Compare
tbs_class.php
Outdated
| @@ -15,8 +14,9 @@ | |||
| */ | |||
|
|
|||
| // Check PHP version | |||
| if (version_compare(PHP_VERSION,'5.0')<0) echo '<br><b>TinyButStrong Error</b> (PHP Version Check) : Your PHP version is '.PHP_VERSION.' while TinyButStrong needs PHP version 5.0 or higher. You should try with TinyButStrong Edition for PHP 4.'; | |||
| /* COMPAT#1 */ | |||
| if (version_compare(PHP_VERSION, '5.0') < 0) { | |||
tbs_class.php
Outdated
| if (version_compare(PHP_VERSION,'5.0')<0) echo '<br><b>TinyButStrong Error</b> (PHP Version Check) : Your PHP version is '.PHP_VERSION.' while TinyButStrong needs PHP version 5.0 or higher. You should try with TinyButStrong Edition for PHP 4.'; | ||
| /* COMPAT#1 */ | ||
| if (version_compare(PHP_VERSION, '5.0') < 0) { | ||
| echo '<br><b>TinyButStrong Error</b> (PHP Version Check) : Your PHP version is ' . PHP_VERSION . ' while TinyButStrong needs PHP version 5.0 or higher. You should try with TinyButStrong Edition for PHP 4.'; |
simonschaufi
force-pushed
the
reformat-code
branch
from
004de82 to
092001b
Compare
|
The problem is PHP 5.3 is 20% used of the PHP 5 versions, just quite as much as PHP 5.4 |
|
Well, one day, sooner or later you have to say: From now on I won't support totally outdated php versions any more (and php 5.3 is totally outdated). Officially supported is just php5.6 at the moment. Of course after merging this, the second or even the first version number should be raised up as it will break existing systems if they try to upgrade and still have 5.3 running. So imho a new major version should be released. |
|
@Skrol29 Are you still interested in this PR? I just found it again while browsing through my open PRs. Should I clean this up so it can be merged? |
3 participants
No code changes, just reformating and replacing array() with []