Skip to content

implemented isTransparent props to override modal transparency, imple… #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
isaaclem wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implemented isTransparent props to override modal transparency, imple… #4

isaaclem wants to merge 1 commit into from

Conversation

@isaaclem
Copy link

@isaaclem isaaclem commented Mar 3, 2019

…mented textInputProps to support all base textinput props

@isaaclem
implemented isTransparent props to override modal transparency, imple…
4b3d255 
…mented textInputProps to support all base textinput props
shimonbr
shimonbr approved these changes Jan 14, 2020
View reviewed changes
Copy link

@shimonbr shimonbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good

@SkrewEverything
Copy link
Owner

SkrewEverything commented Nov 11, 2020

@isaaclem @shimonbr Hi and sorry for not maintaining and no replies. Let me know if you are still using this. I'm thinking to update the repo with the new versions and pull requests to maintain it properly from now onwards

@flexbox
Copy link

flexbox commented Nov 13, 2020

the isTransparent={false} looks nice because with a dark background the TextInput is barelly visible

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shimonbr shimonbr shimonbr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isaaclem @SkrewEverything @flexbox @shimonbr