let map and handbook take the full height#3
Open
janzarsky wants to merge 1 commit intoSkautDevs:masterfrom
Open
let map and handbook take the full height#3janzarsky wants to merge 1 commit intoSkautDevs:masterfrom
janzarsky wants to merge 1 commit intoSkautDevs:masterfrom
Conversation
On these pages, headings are not necessary, remove them. Set map height to 100vh.
|
Sadly, 100vh is not correct - slider appears on the side and footer is pushed on the bottom Care to fix? |
Author
|
This was my intention - I think that slider is not a problem, the problem is that the menu and footer are taking too much space that would be better used by the map. But both approaches are fine with me - if you don't want the slider and if you agree with removal of headings, I can fix the height to calc(100vh - stuff). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On these pages, headings are not necessary, remove them. Set map height to 100vh.