when only one role available, autoselect it and continue to dashboard rightaway.#327
Open
when only one role available, autoselect it and continue to dashboard rightaway.#327
Conversation
tomtomklima
reviewed
Aug 9, 2025
Comment on lines
+32
to
+42
| private ParticipantRepository $participantRepository, | ||
| private TroopParticipantRepository $troopParticipantRepository, | ||
| private PaymentService $paymentService, | ||
| private UserService $userService, | ||
| private FlashMessagesBySession $flashMessages, | ||
| private TranslatorInterface $translator, | ||
| private Mailer $mailer, | ||
| private SaveFileHandler $saveFileHandler, | ||
| private UploadFileHandler $uploadFileHandler, | ||
| ) { | ||
| private PaymentService $paymentService, | ||
| private UserService $userService, | ||
| private FlashMessagesBySession $flashMessages, | ||
| private TranslatorInterface $translator, | ||
| private Mailer $mailer, | ||
| private SaveFileHandler $saveFileHandler, | ||
| private UploadFileHandler $uploadFileHandler, | ||
| ) | ||
| { |
Contributor
There was a problem hiding this comment.
zbytečně přidaný whitespace, není potřeba
|
|
||
| if ($event->eventType->enforceActiveSkautisMembership() | ||
| && $participant->getUserButNotNull()->loginType === UserLoginType::Skautis | ||
| && !(bool)$participant->getUserButNotNull()->skautisHasMembership) { |
Contributor
There was a problem hiding this comment.
komplikované přetypování, stačilo by porovnat s true třeba
Suggested change
| && !(bool)$participant->getUserButNotNull()->skautisHasMembership) { | |
| && $participant->getUserButNotNull()->skautisHasMembership !== true) { |
Comment on lines
+443
to
+444
| ): AbstractContentArbiter | ||
| { |
Contributor
There was a problem hiding this comment.
zbytečně přidaný whitespace, není potřeba
Comment on lines
+118
to
+120
| if ( | ||
| $user->loginType === UserLoginType::Skautis && | ||
| !$this->skautisService->isUserLoggedIn() |
Contributor
There was a problem hiding this comment.
Je tu bummer s tím, že se to nemusí použít jen na Korbo a je potřeba, aby to fungovalo i s eventy, kde je na přihlášení použitý email místo skautisu. Ale vlastně by to mělo jít celé smazat a mělo by to fungovat i s tím myslím
Comment on lines
+141
to
+145
| $user->loginType === UserLoginType::Skautis && | ||
| !$this->skautisService->isUserLoggedIn() | ||
| ) { | ||
| $this->flashMessages->error('flash.error.skautisUserNotLoggedIn'); | ||
| return $this->redirect($request, $response, 'landing'); |
Contributor
There was a problem hiding this comment.
Potřeba zachovat přepoužitelnost i pro eventy, kde se přihlašuješ mailem. Smazal bych a bude fungovat OK myslím
Comment on lines
+132
to
+135
|
|
||
| if ($user->loginType === UserLoginType::Skautis) { | ||
| $this->skautisService->prefillDataFromSkautis($participant); | ||
| } |
Contributor
There was a problem hiding this comment.
Toto mega dává smysl. Nejradši bych sem přesunul logiku i z UserController, aby to mohlo být jen jednou
tomtomklima
force-pushed
the
staging
branch
from
c85d9fb to
f64c6a6
Compare
kaplan-michael
force-pushed
the
staging
branch
from
f64c6a6 to
e03037e
Compare
tomtomklima
force-pushed
the
staging
branch
2 times, most recently
from
4d948a5 to
6c3709c
Compare
tomtomklima
force-pushed
the
staging
branch
2 times, most recently
from
b6c3333 to
3c8df25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.