Open
Conversation
moved font and color css handling to new theme css file;
also handle null logo urls from twig.
tomtomklima
commented
Nov 23, 2024
| public static function getFullLogoUrl(?string $logoUrl): string | ||
| { | ||
| if ($logoUrl === null) { return "";} | ||
| return "/assets" . $logoUrl; |
Contributor
Author
There was a problem hiding this comment.
Takto natvrdo vypálená adresa do kódu není dobře - když to budeme chtít přesunout, tak budeme muset změnit kód, což je špatně. Lepší by bylo toto zanést do infra, aby webserver hledal v této složce automaticky a kód appky to vůbec nemusel vědět
Collaborator
There was a problem hiding this comment.
Promiň, ale vůbec tedy nevím jak bych to měl já udělat
| public function getSkautLogoPath(Participant $participant): string | ||
| { | ||
| return '/SKAUT_horizontalni_logo_250.png'; | ||
| return '/assets/SKAUT_horizontalni_logo_250.png'; |
Contributor
Author
There was a problem hiding this comment.
dtto v src/Event/Event.php
| $email->context(array_merge($parameters, [ | ||
| 'fullRegistrationLink' => $this->settings->getFullUrlLink(), | ||
| 'eventImageExists' => is_file(__DIR__ . '/../../public/' . $event->logoUrl), | ||
| 'eventImageExists' => is_file(__DIR__ . '/../../public/' . Event::getFullLogoUrl($event->logoUrl)), |
Contributor
Author
There was a problem hiding this comment.
Není potřeba volat staticky, když máme k dispozici už konkrétní objekt, kde to je
| </title> | ||
|
|
||
| <link rel="shortcut icon" href="/favicon-16x16.png" type="image/x-icon"> | ||
| <link rel="shortcut icon" href="../../../public/assets/favicon-16x16.png" type="image/x-icon"> |
Contributor
Author
There was a problem hiding this comment.
dtto src/Event/Event.php
Comment on lines
+23
to
+29
| public function getFunctions() :array | ||
| { | ||
| return [ | ||
| new TwigFunction('eventLogo', [Event::class, 'getFullLogoUrl']), | ||
| ]; | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
není potřeba, když se nebude volat staticky
| {% if event is not null %} | ||
| <a href="{{ event.webUrl }}" class="footer-item" target="_blank"> | ||
| <img class="footer-logo" src="{{ event.logoUrl }}" alt="logo of {{ event.readableName }}"> | ||
| <img class="footer-logo" src="{{ eventLogo(event.logoUrl) }}" alt="logo of {{ event.readableName }}"> |
Contributor
Author
There was a problem hiding this comment.
dtto src/Settings/TwigExtension.php
| {% if eventImageExists %} | ||
| <a href="{{ event.webUrl }}" class="footer-item" target="_blank"> | ||
| <img class="footer-logo" src="{{ email.image( event.logoUrl ) }}" alt="logo of {{ event.readableName }}"> | ||
| <img class="footer-logo" src="{{ email.image(eventLogo(event.logoUrl)) }}" alt="logo of {{ event.readableName }}"> |
Contributor
Author
There was a problem hiding this comment.
dtto src/Settings/TwigExtension.php
| {% if eventImageExists %} | ||
| <a href="{{ event.webUrl }}" class="footer-item" target="_blank"> | ||
| <img class="footer-logo" src="{{ email.image( event.logoUrl ) }}" alt="logo of {{ event.readableName }}"> | ||
| <img class="footer-logo" src="{{ email.image(eventLogo(event.logoUrl)) }}" alt="logo of {{ event.readableName }}"> |
Contributor
Author
There was a problem hiding this comment.
dtto src/Settings/TwigExtension.php
tomtomklima
force-pushed
the
staging
branch
2 times, most recently
from
08f97f2 to
abbce93
Compare
paaton
force-pushed
the
staging
branch
2 times, most recently
from
018e2ee to
bac2b63
Compare
tomtomklima
force-pushed
the
staging
branch
2 times, most recently
from
16ee02a to
8d5f87d
Compare
paaton
force-pushed
the
staging
branch
2 times, most recently
from
9c3ace6 to
921ae07
Compare
tomtomklima
force-pushed
the
staging
branch
2 times, most recently
from
b53d9fc to
3d7ad63
Compare
tomtomklima
force-pushed
the
staging
branch
from
c85d9fb to
f64c6a6
Compare
kaplan-michael
force-pushed
the
staging
branch
from
f64c6a6 to
e03037e
Compare
tomtomklima
force-pushed
the
staging
branch
2 times, most recently
from
4d948a5 to
6c3709c
Compare
tomtomklima
force-pushed
the
staging
branch
2 times, most recently
from
b6c3333 to
3c8df25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.