fix: Replace MD5 with sha256 (trimmed to 48 characters)#69
Open
skalar-bcawkwell wants to merge 1 commit intoSkalar:masterfrom
Open
fix: Replace MD5 with sha256 (trimmed to 48 characters)#69skalar-bcawkwell wants to merge 1 commit intoSkalar:masterfrom
skalar-bcawkwell wants to merge 1 commit intoSkalar:masterfrom
Conversation
Many postgresql deployments are now using FIPS mode, which means `MD5()` is no longer generally available. Although channel names can be plain strings I guess there was some concern that potentially the channel name will end up more than 63 characters long, so I switched it to use sha256 instead but trim the output to 48 characters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many postgresql deployments are now using FIPS mode, which means
MD5()is nolonger generally available. Although channel names can be plain strings I guess
there was some concern that potentially the channel name will end up more than
63 characters long, so I switched it to use sha256 instead but trim the output
to 48 characters.