feat: Add Dynamic ISF data accumulation progress indicator#16
Draft
Sjoerd-Bo3 wants to merge 1 commit intodevfrom
Draft
feat: Add Dynamic ISF data accumulation progress indicator#16Sjoerd-Bo3 wants to merge 1 commit intodevfrom
Sjoerd-Bo3 wants to merge 1 commit intodevfrom
Conversation
- Created DynamicISFProgressView component showing data collection progress - Shows progress bar with percentage and days of data collected - Updates DynamicSettingsStateModel to track current and required data points - Displays progress indicator when Dynamic ISF is not yet available - Follows dnzxy's suggestion for progress bar instead of precise countdown - Addresses issue nightscout#560 for better transparency during 7-day warmup period
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Description
This PR implements a progress tracking system for Dynamic ISF to address user confusion about when the feature becomes active. The new progress indicator clearly shows:
Key Features
Progress View Component: Clean, reusable SwiftUI component with:
Data Tracking:
UI Integration:
Test plan
Screenshots