-
Notifications
You must be signed in to change notification settings - Fork 74
Y pl dev #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Y pl dev #715
Changes from all commits
88de3e2
a20c03b
5d651cd
22edbcc
1261558
6bc7250
77962c0
b931799
386c37f
49c6ac6
805ccc7
a4cb339
4308598
e37e5fb
84947e0
8b8bbca
c8ce809
11ced07
01aaea3
c0c1fd0
9a782b8
c643738
64ba8d6
57a47e5
a2daf77
a65935b
e9156b4
87943a8
2423d92
2818df5
c001ecf
1988790
f652b4b
43b9079
283b475
a9d6f6d
5078647
0b480e6
c9b3a60
1a1d83c
64f2dcf
d854802
5a13f6c
51d06b7
101ffad
0ac5074
a78ad91
8e8e0cf
d711676
c378c2e
5703217
f96f120
d2b73ca
e9f769d
412b92b
de4c04e
e65942f
dd5603a
6fbf72b
93c6a69
70740c9
1772a7b
ba30833
f32c033
8546f70
1337d35
e1ce440
adf6827
6c14b2d
f283434
aa9b90c
d94559b
53ac656
ed7f409
47aac8f
6724bd9
588857c
27ff36c
9131f86
3f8a2b2
73982e0
2986c35
d7ce3d8
ec5a0d6
b7927eb
3e23e9c
b511c0b
7a7f5ab
736a513
c600c67
128686b
9788c9b
3a8fc9b
459c1f2
2a86c35
0c93771
030aca9
ee0e6f0
90f718b
cd34d11
3b93fc4
9e9e28c
fe3c0e2
bcdddf9
211360e
803c093
1abb189
7b0c679
7263a05
f02bcae
0185c92
9dac3c3
2b1172b
b51c6bb
24c79e7
6c69990
7cd3259
8050af9
82879ac
b777ae8
fb34a5c
3db6685
d11747c
306ab95
87cf8cf
97b43e7
c7cec57
64d2f55
70ccf84
2fe1fad
435844a
13d0966
807e0e7
d5a416f
c934a2c
b53d8f9
50702fa
cb44cff
35f4604
c41739b
7c3a4e5
8b68f78
8eabfa9
a77e7bc
490e618
90c6f43
be4180d
c5c93d9
54d4063
2bd9416
05003e2
580094d
d900410
1033965
099b092
466d699
925987a
761c015
41a5816
77eb0e8
8001abe
478acd8
22fec57
9796953
1823825
e6bf55a
f46177f
0b9988f
bd139b6
44cdc8a
9cbbf30
826df80
d7960a6
1a648e2
e7e2bab
df3266b
01093dc
c8f245c
10857bc
bdcd7b1
4af4f83
3ec413c
a31441f
d118836
b5c3180
6cd7095
dc8353a
f43a510
f0d5ace
4449594
f4f1d11
692f492
b05d83e
30349ab
fcad390
dd0aa2e
cfaf12e
57866f6
88e7a2e
e834d8b
1643423
c067c6f
c78e41a
92800fa
d99564b
7a8476d
833ec4a
5dbb39f
8156b5c
efa5828
f21dc02
4ebd5ec
56aafdc
c3304c1
0218b62
1593d62
cff4765
041cdad
0bd6cd2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,34 @@ | ||||||||||||||||||||||||||||||||||||||||||||||||
| name: Send Release Webhook | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| on: | ||||||||||||||||||||||||||||||||||||||||||||||||
| release: | ||||||||||||||||||||||||||||||||||||||||||||||||
| types: [published] | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| workflow_dispatch: # מאפשר הפעלה ידנית | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+3
to
+8
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Manual trigger has no release context — envs will be empty. When run via workflow_dispatch, github.event.release.* is undefined, so RELEASE_* envs become empty and the script may misbehave. Add inputs and coalesce with release event fields. Apply this diff: on:
release:
types: [published]
- workflow_dispatch: # מאפשר הפעלה ידנית
+ workflow_dispatch: # מאפשר הפעלה ידנית
+ inputs:
+ release_tag:
+ description: "Tag (e.g., v1.2.3)"
+ required: true
+ release_name:
+ description: "Release name"
+ required: false
+ release_body:
+ description: "Release notes (optional)"
+ required: false
+ release_url:
+ description: "Release URL (optional)"
+ required: falseAnd coalesce env vars (see lines 26-34 diff in a separate comment). 📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||
| jobs: | ||||||||||||||||||||||||||||||||||||||||||||||||
| send_webhook: | ||||||||||||||||||||||||||||||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| steps: | ||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Checkout repository | ||||||||||||||||||||||||||||||||||||||||||||||||
| uses: actions/checkout@v4 | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Set up Python | ||||||||||||||||||||||||||||||||||||||||||||||||
| uses: actions/setup-python@v5 | ||||||||||||||||||||||||||||||||||||||||||||||||
| with: | ||||||||||||||||||||||||||||||||||||||||||||||||
| python-version: '3.12' | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Install dependencies | ||||||||||||||||||||||||||||||||||||||||||||||||
| run: pip install bs4 requests pyluach | ||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+22
to
+24
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unpinned Python deps in CI. Installing bs4/requests/pyluach without pinning is a supply‑chain risk and harms reproducibility. Prefer a hashed requirements file. Suggested change (you’ll need to add webhooks/requirements.txt with pinned versions and --hash entries): - - name: Install dependencies
- run: pip install bs4 requests pyluach
+ - name: Install dependencies
+ run: |
+ python -m pip install --upgrade pip
+ python -m pip install --require-hashes -r webhooks/requirements.txtMinor: install beautifulsoup4 instead of the bs4 shim for clarity.
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||||||||||||||||
| - name: Run webhook script | ||||||||||||||||||||||||||||||||||||||||||||||||
| env: | ||||||||||||||||||||||||||||||||||||||||||||||||
| RELEASE_TAG: ${{ github.event.release.tag_name }} | ||||||||||||||||||||||||||||||||||||||||||||||||
| RELEASE_NAME: ${{ github.event.release.name }} | ||||||||||||||||||||||||||||||||||||||||||||||||
| RELEASE_BODY: ${{ github.event.release.body }} | ||||||||||||||||||||||||||||||||||||||||||||||||
| RELEASE_URL: ${{ github.event.release.html_url }} | ||||||||||||||||||||||||||||||||||||||||||||||||
| USER_NAME: ${{ secrets.USER_NAME }} | ||||||||||||||||||||||||||||||||||||||||||||||||
| PASSWORD: ${{ secrets.PASSWORD }} | ||||||||||||||||||||||||||||||||||||||||||||||||
| TOKEN_YEMOT: ${{ secrets.TOKEN_YEMOT }} | ||||||||||||||||||||||||||||||||||||||||||||||||
| run: python webhooks/main.py | ||||||||||||||||||||||||||||||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Feature-branch pushes will create full releases
With these branches under on.push, the create_release job (if: github.event_name == 'push') will publish normal releases for feature branches (non-dev), tagging v. Restrict push branches or gate the job by branch.
Option A (simplest): keep releases only for main/dev.
- main - dev - dev_dev2 - - n-search2 - - ns2new - - n-search2.1Option B (also recommended): additionally guard the job (outside this hunk):
To ensure no unintended releases already went out:
🏁 Script executed:
Length of output: 1570
Restrict create_release to main and dev branches
Verified the last 20 GitHub releases – no full releases were created for feature branches. Remove those branches from the workflow trigger or gate the release job.
Option A (update branches under on.push):
- main - dev - dev_dev2 - - n-search2 - - ns2new - - n-search2.1Option B (add job‐level guard):
🤖 Prompt for AI Agents