#775 | Add the backup functionality for Sitecore 9 and later#793
#775 | Add the backup functionality for Sitecore 9 and later#793ElenaBovdui wants to merge 1 commit intodevelopfrom
Conversation
DmitryKolinchuk
left a comment
DmitryKolinchuk
left a comment
There was a problem hiding this comment.
Additional points:
- SIM is hanging when the Restore or Clear button is pressed.
Can we add a long running task dialog for better user experience? - When using these buttons and no backups exist, can we display a small dialog notifying a user about backups absence instead of loading empty main dialogs?
- It is impossible to go back to the previous step in the following dialog window:
- The same window may hang when clicking the Backup button.
Should we also add a long running task dialog for better user experience? - Can we display the same info in the Clear dialog as in Restore since the last one contains more clear details what is include to the backup and its creation date?
- The empty backups folder still exists in the root folder of the Sitecore environment after clearing all backups.
Can it be removed when all backups are removed?
There was a problem hiding this comment.
The logic of this class is same as in BackupProcessor, but only type of args is different. Can we update BackupProcessor to use an interface for args?
There was a problem hiding this comment.
The logic of this class is same as in BackupFiles, but only type of args is different. Can we update BackupFiles to use an interface for args?
There was a problem hiding this comment.
The logic of this class is similar to BackupArgs. Can we extend BackupArgs instead of creating this new class or inherit it?
There was a problem hiding this comment.
Please do not use regions (#region and #endregion) since they are considered as anti-patterns.
I would suggest removing them from each class.
There was a problem hiding this comment.
The logic of this class is similar to BackupDatabases. Can we extend BackupDatabases instead of creating this new class or inherit it?
| SelectedBackups = backups; | ||
| Instance = instance; | ||
| } | ||
|
|
There was a problem hiding this comment.
Remove additional empty line
| @@ -0,0 +1,61 @@ | |||
| namespace SIM.Tool.Windows.UserControls.Backup | |||
| { | |||
| using SIM.Core.Common; | |||
There was a problem hiding this comment.
The following usings can be removed since they are not used:
using SIM.Core.Common;
using SIM.FileSystem;
using SIM.IO.Real;
using SIM.Pipelines.Backup;
using SIM.Pipelines.Restore;
using SIM.Tool.Base.Profiles;
using System.Data.SqlClient;
using Profile = Core.Common.Profile;
| xmlns:d="http://schemas.microsoft.com/expression/blend/2008" | ||
| mc:Ignorable="d" d:DesignHeight="205" d:DesignWidth="443"> | ||
| <Grid> | ||
| <ListBox IsManipulationEnabled="True" Name="backups" Padding="0,5,0,0" SelectedIndex="0" Grid.ColumnSpan="2"> |
There was a problem hiding this comment.
Change backups to Backups.
| </steps> | ||
| </backup> | ||
|
|
||
| <backup9AndLater title=""Backing up the {InstanceName} instance"" startButton=""Backup"" |
There was a problem hiding this comment.
Use the same formatting like in the backup section, pay attention to spaces and empty lines.
| /*Restore*/ | ||
| "RestoreInstanceButton", | ||
| "ClearBackupsInstance9AndLaterButton", | ||
|
|
There was a problem hiding this comment.
Remove empty line.
| "RefreshButton", | ||
| "BackupInstanceButton", | ||
| "BackupInstance9AndLaterButton", | ||
|
|
There was a problem hiding this comment.
Remove empty line.
| public BackupFileName() | ||
| { | ||
| InitializeComponent(); | ||
| BackupName.Text = string.Format("{0:yyyy-MM-dd} at {0:hh-mm-ss}", DateTime.Now); |
There was a problem hiding this comment.
Let's maybe use name like SitecoreBackup instead since we still display date and time in the Restore and Clear dialogs.
DmitryKolinchuk
moved this from To be triaged
to To do: milestone 2025Q1
in Main SIM project
DmitryKolinchuk
moved this from To do: milestone 2025Q1
to In Progress: 2025Q1
in Main SIM project
3 participants
No description provided.