Prevent crash when modifying the shape before _ready()#200
Merged
limbonaut merged 1 commit intoSirRamEsq:masterfrom Oct 27, 2025
Merged
Prevent crash when modifying the shape before _ready()#200limbonaut merged 1 commit intoSirRamEsq:masterfrom
limbonaut merged 1 commit intoSirRamEsq:masterfrom
Conversation
Shapes becomes dirty upon scene load. The dirty update is called deferred, so `_ready()` already ran. This does not seem to be the case when calling `get_tree().reload_current_scene()`. For whatever reason, the deferred `_on_dirty_update` call already runs before the node was added to the scene. This patch prevents dirty updates before the shape is ready. Closes SirRamEsq#197
limbonaut
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge this after #199.
Shapes becomes dirty upon scene load. The dirty update is called deferred, so
_ready()already ran.This does not seem to be the case when calling
get_tree().reload_current_scene(). For whatever reason, the deferred_on_dirty_updatecall already runs before the node was added to the scene.This patch prevents dirty updates before the shape is ready.
Closes #197