Update Publish Action #4
Conversation
Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
DEATHB4DEFEAT
added
Priority: 2-High
Signed-off-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR refactors the publish workflow to use configurable variables and secrets instead of hardcoded values, making the workflow more maintainable and reusable. The changes also update naming from "robust"/"Suns" to "engine" to better reflect the current project structure.
- Replaces hardcoded host, username, and key values with GitHub variables and secrets
- Updates naming conventions from "robust-builds" to "engine-builds"
- Updates step name from "Upload files to Suns" to "Upload files to server"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
| host: ${{ vars.ENGINE_BUILDS_HOST }} | ||
| username: ${{ vars.ENGINE_BUILDS_PUSH_USER }} | ||
| key: ${{ secrets.ENGINE_BUILDS_PUSH_KEY }} | ||
| script: /home/${{ vars.ENGINE_BUILDS_PUSH_USER }}/engineManifestGenerator/bin/Release/net7.0/ss14ManifestGenerator ${{ steps.parse_version.outputs.version }} |
There was a problem hiding this comment.
The script path references ss14ManifestGenerator but is located in the engineManifestGenerator directory. This naming inconsistency suggests the executable name may not have been updated during the refactoring from "robust"/"ss14" to "engine" naming. Consider renaming the executable to engineManifestGenerator or verifying the correct executable name.
| script: /home/${{ vars.ENGINE_BUILDS_PUSH_USER }}/engineManifestGenerator/bin/Release/net7.0/ss14ManifestGenerator ${{ steps.parse_version.outputs.version }} | |
| script: /home/${{ vars.ENGINE_BUILDS_PUSH_USER }}/engineManifestGenerator/bin/Release/net7.0/engineManifestGenerator ${{ steps.parse_version.outputs.version }} |
No description provided.