Skip to content

Conversation

@DEATHB4DEFEAT
Copy link
Member

@DEATHB4DEFEAT DEATHB4DEFEAT commented Feb 1, 2025

No description provided.

@DEATHB4DEFEAT DEATHB4DEFEAT marked this pull request as ready for review February 23, 2025 01:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

Robust.Client/Graphics/Clyde/Clyde.Rendering.cs:420

  • When disabling the scissor test, a call to CheckGlError() is omitted. For consistent error checking and debugging, consider invoking CheckGlError() after disabling the state.
else { GL.Disable(EnableCap.ScissorTest); }

Comment on lines 82 to 86
var userId = Guid.Parse(reader.GetString(0));
var userName = reader.GetString(1);
var token = reader.GetString(2);
serverUrl = reader.GetString(4);

Copy link

Copilot AI Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding the column index when retrieving the serverUrl makes the code fragile if the query order ever changes. Consider using named columns or defined constants to ensure the correct value is extracted even if the SQL query is updated.

Suggested change
var userId = Guid.Parse(reader.GetString(0));
var userName = reader.GetString(1);
var token = reader.GetString(2);
serverUrl = reader.GetString(4);
var userId = Guid.Parse(reader.GetString(reader.GetOrdinal("UserId")));
var userName = reader.GetString(reader.GetOrdinal("UserName"));
var token = reader.GetString(reader.GetOrdinal("Token"));
serverUrl = reader.GetString(reader.GetOrdinal("ServerUrl"));

Copilot uses AI. Check for mistakes.
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Multiauth Multiauth & Update May 27, 2025
@DEATHB4DEFEAT DEATHB4DEFEAT changed the title Multiauth & Update Multiauth Jul 11, 2025
@DEATHB4DEFEAT DEATHB4DEFEAT merged commit 5fa00c7 into Simple-Station:master Nov 30, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant