-
Notifications
You must be signed in to change notification settings - Fork 5
Multiauth #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiauth #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 52 out of 52 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Robust.Client/Graphics/Clyde/Clyde.Rendering.cs:420
- When disabling the scissor test, a call to CheckGlError() is omitted. For consistent error checking and debugging, consider invoking CheckGlError() after disabling the state.
else { GL.Disable(EnableCap.ScissorTest); }
| var userId = Guid.Parse(reader.GetString(0)); | ||
| var userName = reader.GetString(1); | ||
| var token = reader.GetString(2); | ||
| serverUrl = reader.GetString(4); | ||
|
|
Copilot
AI
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding the column index when retrieving the serverUrl makes the code fragile if the query order ever changes. Consider using named columns or defined constants to ensure the correct value is extracted even if the SQL query is updated.
| var userId = Guid.Parse(reader.GetString(0)); | |
| var userName = reader.GetString(1); | |
| var token = reader.GetString(2); | |
| serverUrl = reader.GetString(4); | |
| var userId = Guid.Parse(reader.GetString(reader.GetOrdinal("UserId"))); | |
| var userName = reader.GetString(reader.GetOrdinal("UserName")); | |
| var token = reader.GetString(reader.GetOrdinal("Token")); | |
| serverUrl = reader.GetString(reader.GetOrdinal("ServerUrl")); |
the last was engine version
…it fixed it EIGHT HOURS
No description provided.