-
Notifications
You must be signed in to change notification settings - Fork 3
chore: 🚧 Provide support for rive pre-release #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if possible dont update sdk and flutter version. and create a pre-release for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to pre-release version 0.0.4-dev.1 in commit 5593c48.
Note: The SDK constraints (Flutter >=3.27.0 and Dart SDK >=3.6.0) are required by Rive 0.14.0-dev.14 itself and cannot be lowered. These are hard requirements from the Rive package's own pubspec.yaml.
lib/splashes/rive/rive_config.dart
Outdated
| this.layoutScaleFactor = 1.0, | ||
| this.placeHolder, | ||
| this.splashDuration, | ||
| this.riveFactory = Factory.rive, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factory.rive is not constant so providing it as default param will not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit d0226c3. Changed riveFactory to be nullable (Factory?) so the const constructor works. The default value Factory.rive is now applied at runtime when null.
|
@copilot instead of adding deprecated member just remove them |
7574b99 to
0fb226e
Compare
0fb226e to
866b279
Compare
Description
Updates Splash Master to support Rive 0.14.0-dev.14 pre-release, which uses an entirely new C++ runtime-based API replacing the previous Dart implementation.
This is released as version 0.0.4-dev.1 (pre-release).
API Changes
artboardName/animations/stateMachineNamewithartboardSelector/stateMachineSelector. ChangedfitfromBoxFitto Rive'sFitenum. AddedriveFactoryparameter (nullable, defaults toFactory.riveat runtime).RiveWidgetBuilder+RiveWidgetinstead of removedRiveAnimationwidget.RiveFileSourcefor pre-loaded files. RemovedRiveArtboardSource(not functional with Rive 0.14.x).Unsupported in Rive 0.14.x
DeviceFileSourceandBytesSourceare no longer supported for Rive splash (useAssetSource,NetworkFileSource, orRiveFileSource)SDK Requirements
The SDK constraints (Flutter >=3.27.0 and Dart SDK >=3.6.0) are required by Rive 0.14.0-dev.14 itself and cannot be lowered.
Example
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Migration instructions
Update to Flutter
>=3.27.0and Dart SDK>=3.6.0(required by Rive 0.14.0-dev.14)Replace
RiveArtboardSourcewithRiveFileSource(the old class has been completely removed)Update
RiveConfigto use new selector-based APIMigrate
DeviceFileSource/BytesSourceRive sources toAssetSourceorNetworkFileSourceNote:
riveFactoryparameter is now optional and nullable (defaults toFactory.rive)Yes, this PR is a breaking change.
No, this PR is not a breaking change.
Related Issues
Closes #75
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.