-
Notifications
You must be signed in to change notification settings - Fork 12
dynamic object properties #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
albertz
wants to merge
30
commits into
Silviu-Marian:master
Choose a base branch
from
albertz:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+254
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hello there. Thanks for giving time to this. |
Owner
|
Ok so, I have the changes locally and need to test them. There's a couple of bits I don't like and maybe we can make some changes. |
Author
|
You need dynamic attributes, like this: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the case that I have some complex objects which have dynamic properties (defined via get functions) in their prototypes.
Currently, because of the
Object.prototype.hasOwnPropertycheck in stringify, attributes from parent prototypes wont be shown at all. That is simple to change and already almost always what you probably want (I guess).However, for my use case, that change is of course not enough. I added some more code which checks if a property is defined via a get-function, via
Object.getOwnPropertyDescriptor. The client shows this as a placeholder and if the user requests to show the property, the clients send such request to the server. To make that possible, you need to keep some reference to the object on the server in case for a later request. I have introduced a small and simple object cache, where I assign a new id to a new object. This id is sent to the client and the client uses this id in its requests. I also extended thejsencrfunction a bit to cover this.