Open
Conversation
…ing KeySetId … (#43094) * Fix TC_GCAST_2.3 .4 .5 .6 test setup by remove all existing KeySetId and allowing LeaveGroup All return NotFound if the fabric had no groups * Apply suggestions from code review Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Address comments. Check for membership entry before sending a leavegroup all * Fixup small difference needed for 2_6 --------- Co-authored-by: Tennessee Carmel-Veilleux <tennessee.carmelveilleux@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* [Darwin] add private umbrella header * add private modulemap to xcconfig * remove Project scoped header from private umbrella `MTRCommandPayloads_Private.h` is a misnomer; it's Project scoped. * regenerate private headers from updated templates * place reserved IDs to avoid empty enums * add local test storage to private module map * additional private modulemap qualifications * annotate private clusters as MTR_PROVISIONALLY_AVAILABLE
* controller: Support thread meshcop commissioning for python controller * use onboardingpayload * Revert "use onboardingpayload" This reverts commit 7637e31cca57fe68200b6fe336186d31f8c34962. * Add python script for TC_SC_TC_4.1 * Restyled by autopep8 * refactor the code --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Yakun Xu <xyk@google.com>
…gn with specification PR#12703 (#43074) * Update .xml and source code of ambient context sensing cluster to align with specification PR#12703 Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com> * Restyled by prettier-json * * Regenerate ambient-context-sensing-cluster.xml by remove the existing one and use alchemy to regenerate it again * Regenerate the code from zap_regen_all.py * Remove AmbientContextSensingClusterAmbientContextDetectedEvent.kt, since the event is removed in the latest specification Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com> * Change fieldId to "id" to pass matter-zapxml-parser Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com> --------- Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io>
…m (#43053) * [NXP][platform][zephyr] Initial enablement of Matter-over-Thread for NXP Zephyr * Enabling NET_L2_OPENTHREAD and CHIP_OPENTHREAD_FTD for zephyr platform * Adding application MoT ZAP file and prj_thread_ftd.conf * Adding openthread configurations with Kconfig * Adding MbedTLS and PSA Kconfig required for MoT functionality * Increasing stack sizes for some tasks to avoid stack overflow * Enabling the "CONFIG_CHIP_USE_OT_ENDPOINT" to use the OT TCP/UDP stack directly Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> * [NXP][Zephyr][build_examples] Adding support for Matter-over-Thread for Zephyr platform in the CI Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> * Restyled by ruff * [NXP][Zephyr][examples] Remove the INCLUDE_SERVER parameter as it is not used by the chip_configure_data_model function Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> --------- Signed-off-by: Dina Benamar <dina.benamarelmaaroufi@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices. * Added 'linux' as one of the available platform choices.
…testing_infrastrcture (#42800) * Moved commissioning tests to python tests * Restyled by ruff * Restyled by isort * Removed comments * Suppressing import error * Restyled by autopep8 * Restyled by isort * Refactor * Revert "Refactor" This reverts commit 696997a762b2a0b30c9cb9a9dce7468b05e89953. * removed redundant logs * Restyled by ruff * updates in regard to recent master * Restyled by autopep8 * Restyled by isort * added missing file * Restyled by autopep8 * Restyled by isort * broken compilation fix * importing python modules refactor * cleanup in namespaces * decouple thread.py from test definitions * corrected __init__.py to better handle errors * corrected hardcoded interpreter * Restyled by autopep8 * Restyled by isort * Review fixes: python tests do not depend on chiptest * Restyled by autopep8 * Restyled by isort * Review fixes: imports and explicit type definitions * Restyled by autopep8 * Removed not used definitions and declarations * invert parameter order in thread.py * cleanup in imports * Restyled by autopep8 * Restyled by isort * fix after merge * not needed addition removed * removed redundant export * issue after merge * renamed dataset * this kind of changes are not welcome. revert. * Missing LinuxNamespacedExecutor in public linux matter testing API * some extra refactor * Unnecessary refactor in run test suite * Restyled by autopep8 * missing parameter in ThreadBorderRouter * cosmetic refactor --------- Co-authored-by: Restyled.io <commits@restyled.io>
The new class was added in 3.11 (which is our min requirement) and old version was deprecated in 3.12 slated for removal in 3.14. This fixes python 3.14 running tests.
* Groupcast integration. * Groupcast: Code review.
* TC_OCC_3.1 refactor to match the test plan * Added a few Copilot suggestions * remove self.is_ci Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update ci-pics-values to pass steps 12 and 17 * Adding OCC.S.E00 in PICS.yaml * Added the suggestions about changing '.await_sequence_of_reports()' * Fix Restyle error * Fix a type variable * Fix Restyle error --------- Co-authored-by: Andrey Khodyrev <khodyrev@google.com> Co-authored-by: Andrey Khodyrev <akhodyrev@griddynamics.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update ZAP files for Group Key Management cluster * Manual modification on GroupKeySetStruct * Remove only fabric scoping * Update yaml test * Fix tests involving GroupKeySetStruct * Restyled by whitespace * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Fix the potential vulnerability issues.
- underflow issue if mWindowSize is small (or 0)
- Memory leak in ReorderQueue if connection drops unexpectedly
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Restyled by clang-format
* Update src/wifipaf/WiFiPAFConfig.h
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Refine the comment based on Gemini’s suggested wording
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Add more information to the new defined macro
Replace #error with static_assert
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
* Restyled by clang-format
---------
Signed-off-by: Lo,Chin-Ran <chin-ran.lo@nxp.com>
Co-authored-by: Restyled.io <commits@restyled.io>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Amine Alami <43780877+Alami-Amine@users.noreply.github.com>
* make this PR for XML changes only * updated XML using alchemy
* Implement ICACCSRRequest handler guard * Restyled by clang-format * Reset mVerifiedFabricIndex at the start of HandleAnnounceJointFabricAdministrator * Update TC_JFADMIN to test VIDNotVerified response from ICACCSRRequest * Switch pairing command to use onnetwork-long with discriminator * Add missing shutdowns * full compile of todos in HandleICACCSReq, no testing yet * Successful compile of handle ICAC checks, still no tests * change for passing all current tests in JFADMIN2_2 * fixed error on handle fabric index from testing * Quick python testing changes of uncommented test case 8, not fully working * Add test step details * Move commissioning and subsequent actions from setup to step 1 * Rename JFADMIN 2.2 to JFPKI 2.2 * Reimplement test steps using enums instead of strings * Add a try/finally to shut down the resources initialized at the start of the script * Remove outdated todo * Remove unnecessary guard on VIDNotVerified check * Reorder HandleICACCSRRequest checks to satisfy TC_JFPKI_2_2 * Implement JFPKI_2_2 steps 5-7 * Add TC_JFPKI_2.2.py to slow_tests * Implement all TC_JFPKI_2_2 steps except 17 * Use teardown_class for resource shutdown * Refactor to use default_controller * Immediately expire failsafes to speed up the test * Implement Step 17 * Clean up code * Switch to with assert_raises where relevant * Relocate VID verification tracking to joint-fabric-administrator-server * Revert ReadAdministratorFabricIndex implementation * Add PICS and desc * Use new name in desc_TC_JFPKI_2_2 * Implement Copilot feedback * Remove section number from description --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Zack Foreman <z.foreman@cablelabs.com> Co-authored-by: Robert Farnum <robertfarnum@gmail.com>
* Fix unit variable Signed-off-by: Doru-Cristian Gucea <doru-cristian.gucea@nxp.com> * Restyled by clang-format --------- Signed-off-by: Doru-Cristian Gucea <doru-cristian.gucea@nxp.com> Co-authored-by: Restyled.io <commits@restyled.io>
…167) * Update GroupDataProvider Constructor, the Max group per fabric and Max keys per fabric configurations inline with groupcast definitions. Add a unit test for LeaveGroup 0 (ALL) command * Add explicit constructor in the MockGroupDataProvider * Update all-cluster-app config to set CHIP_CONFIG_MAX_GROUPCAST_MEMBERSHIP_COUNT at 24 for backward compatibility of test TestGroupKeyManagementCluster that still usese Groups cluster. Add one additinal key creation in the test inline with groupdataprovider changes. * Restyled by whitespace * Update KeySetWrite command in yaml inline with changes on master --------- Co-authored-by: Restyled.io <commits@restyled.io>
* injecting dependencies for binding cluster. * moving BindingManager CreateBindingEntry logic into BindingCluster. * recovering AddBingingEntry for BindingManager.cpp * Decouple `Binding::Manager` and `Binding::PendingNotificationMap` * Restyled by clang-format * Fix namespace issue * Restyled by clang-format * Finish decoupling * Fix namespace issue * Apply suggestion from @Elen777300 Co-authored-by: Elen777300 <43118262+Elen777300@users.noreply.github.com> * Replace `TEMPORARY_RETURN_INGORED` with `LogErrorOnFailure` * Fix namespace naming issues * Restyled by clang-format * Remove an unnecessary variable --------- Co-authored-by: Hayk10002 <hayk.g.khachatryan@gmail.com> Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: AniDashyan <ani.dashyan77@gmail.com> Co-authored-by: AniDashyan <45006450+AniDashyan@users.noreply.github.com> Co-authored-by: Elen777300 <43118262+Elen777300@users.noreply.github.com>
* Resolve merge conflicts * Fix vaiables; fix tests * Restyled by whitespace * Restyled * Restyled by clang-format * Add dependencies * Restyled by clang-format * Fix rvalue * Fix double initialization * Test * dereference pointer * Restyled by clang-format * Move dac provideer * Restyled by whitespace * Restyled by clang-format * Fix context * Resolve comments * Test * Restyled by whitespace * Restyled by clang-format * Restyled by clang-format * Test PAC * Test DAC * Test DAC * Test obj lifetime * Test * Fix test * Remove std::move * Test * test * Restyled by whitespace * Test * Resolve comments * Test * Restyled by whitespace * Test * Restyled by whitespace * Test * Restyled by whitespace * Restyled by clang-format * Test * Restyled by clang-format * Test * Test * Test * Compilable version * Restyled by whitespace * Test * Restyled by clang-format * test * Test * Chnage ordering * Resolve comments * Fix Merge Conflict * Restyled by clang-format * Fix typo * Remove getters * Restyled by clang-format * Fix init order * Fix Erased * Restyled by whitespace * Change ordering * Change order * Fix ordering * Update src/app/clusters/operational-credentials-server/OperationalCredentialsCluster.cpp --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Replace all usages of ChipLogFailure with ChipLogError The ChipLogFailure() suggests that there is another logging level. However, ChipLogFailure simply calls ChipLogError internally. Since the ChipLogFailure is used only in few places, replace it with ChipLogError to make the codebase consistent. * Do not print error message unconditionally
* Update LoggingSpeakerDevice to log volume percentage with simpler logic * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Enable Groupcast cluster on ligthing-common zap and silabs platforms zap files. * Fix: missing regen on examples/lighting-app/silabs/data_model/lighting-thread-app.matter
* Aling TC_JDADMIN_2_1 with test plan. Integrate PICS * Update src/python_testing/TC_JFADMIN_2_1.py Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Add PICS in PICS file * Restyled by ruff * Restyled by autopep8 * Restyled by prettier-yaml * Update JFADMIN_2_1 with new PICS Code * Add JF subprocess prefix back * Add PICS in JFPKI_2_1. Minor changes in CADMIN_1_27 1_28 * Restyled by ruff * Add PICS in test scripts --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Set the 1.6 DM files base from 1.5.1 - Using the alchemy v1.6.8 (used for 1.5.1) * Update the "base" of 1.6 DM files using the latest alchemy - Using the alchemy v1.6.9 * Generate 1.6 DM files * Update ZAP files for Group Key Management cluster * Update TestSpecParsing* tests for 1.6 * Update spec version references * Manual modification on GroupKeySetStruct * Remove only fabric scoping * Update yaml test * Fix tests involving GroupKeySetStruct * Restyled by whitespace * Restyled by prettier-yaml * Update include list * Update spec version in TestBasicInformation * Update ZAPs for General Diagnostics missing attribute * Update ZAPs for GroupKeyManagement missing feature map * Regenerate zap * Update ZAPs for Root Node Device Revision + Zap regen * Fix ZAPs for GroupKeyManagement missing feature map + Zap Regen * Revert Zap GroupKeyManagement feature + Zap regen * Set Group Key Management feature map in implementation * Support Group Key Management Attribute 0x04 * Disable attribute test for Group Key Management * Restyled by whitespace * Restyled by clang-format * Update device type revisions + read attribute for group key management * fix shadowed variable * Update device revisions * Update General Diagnostics feature map in implementation * Fix typo * Restyled by whitespace * Create 1.6 Data Model files * Update BUILD * Ignore GeneralDiagnostics feature mask 0x02 + Ignore BasicInformation Attribute 0x0018 * Update Groupcast provisionality * Regenerate ZAP --------- Co-authored-by: Restyled.io <commits@restyled.io>
…en. (#43097)
This makes 'CHIP_DEFAULT_{CONFIG,DATA,FACTORY}_PATH' consistent with
'CHIP_CONFIG_KVS_PATH' in "src/platform/Linux/CHIPPlatformConfig.h" in
that they now follow a '#ifndef .. #define .. #endif' pattern such
that they can be overridden.
* se05x crypto architecture updated to make it co-exist with host crypto * updated simw middleware repo * linux build fix * restyle, code-assist review comments fix * typo fix * comments updates, improved code readability * using session close from utils.h file, removed app dependency from crypto build file * removed unused dependency * moving the declaration to #if !ENABLE_SE05X_SPAKE_VERIFIER_USE_TP_VALUES * updated wordlist * readme update * readme update * readme update
…obal dependencies through dependency injection (#43014) * Decouples CameraAvSettingsUserLevelManagementCluster from global dependencies through dependency inejction * Address review comments
…(#43307) * Improvement to illuminance measurement cluster * Code update * Address review comments * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
…t 2) (#43085) * Add DefaultClusterIntegration to reduce boilerplate * [WIFINM] Convert Wi-Fi Network Management cluster to code driven (part 2) * Address review comments * Address review comments * zap regen * make clang-tidy happy * clang-tidy redux * Apply suggestions from code review NotifyAttributeChanged already checks for started Co-authored-by: Sergio Soares <sergiosoares@google.com> * Implement code review suggestion: Keep existing API for ZAP apps * Tweak comments * Move the code gen logic into CodegenIntegration per convention * Test attribute notifications * Restyle and add missing files * Remove DefaultClusterIntegration and Id constant * Improve registration / unregistration and other review comments * Add getters to API and fix notification issue * Revert bogus "fix" suggested by copilot * Use Init / Deinit in the compat wrapper, hex PSK test * Remove from CommandHandlerInterfaceOnlyClusters --------- Co-authored-by: Sergio Soares <sergiosoares@google.com> Co-authored-by: Andrei Litvin <andy314@gmail.com>
* Bump third_party/pigweed/repo from `c21be8f` to `cf08ca9` Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `c21be8f` to `cf08ca9`. - [Commits](pigweed-project/pigweed@c21be8f...cf08ca9) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-version: cf08ca98ed990e79284b3d97eec2b6a334c914f7 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * remove rosetta since rosetta support was removed from pigwed * Patch from Shubham * [nrfconnect] Fix Zephyr native integration with Pigweed * Add Pigweed to `ZEPHYR_EXTRA_MODULES`. * Enable system I/O module. * Set required backends. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Alami-Amine <aalami90@gmail.com> Co-authored-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
* ESP32: handle TEMPORARY_RETURN_IGNORED at a few places Replace TEMPORARY_RETURN_IGNORED with LogErrorOnFailure where functions returns void and return an actual error to the upper layer where functions returns the CHIP_ERROR or value. Also removed few usage of goto after adding error handlings * address review comments
…iFi platform (#43131) * Replace wfx_sec_t with Matter WiFiSecurityBitmap on Silabs WiFi platform * Restyled by clang-format * Address review comments * Modify logic to get AP values on the flow and cache those values * Restyled by clang-format * Address review comments * Restyled by clang-format * Address review comments * Add error handling --------- Co-authored-by: Restyled.io <commits@restyled.io>
…#43283) * Fix: Exclude Fuchsia and musl from GNU strerror_r usage Fuchsia and musl libc do not provide the GNU-specific version of strerror_r (which returns a char*). This commit updates the preprocessor conditions in SystemError.cpp to explicitly exclude `__Fuchsia__` and `__MUSL__`. This ensures these platforms correctly fall back to the standard POSIX-compliant strerror_r (which returns an int), fixing compilation errors when _GNU_SOURCE is defined. * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [Bouffalo Lab] Add BouffaloSDK for bl616 * update to use psram cachable address * [Bouffalo Lab] Re-assign memory address of matter platform task for BL702 (#7) * [Bouffalo Lab] update bl702l compile script for thread commissioning (#8) * fix get thread network interface in DiagnosticDataProviderImpl * update sdk * fix compile error after merge with latest code * update as gemini-code-assist suggested * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Restyled by ruff * Restyled by autopep8 * Restyled by clang-format * fix targets test data * Restyled by clang-format * Restyled by prettier-markdown * resume workflows in a single job * Exclude Bouffalo SDK from run-clang-tidy-on-compile-commands.py execution in build.yaml. * recover build.yaml * remove bouffalo sdk repo * clone bouffalo sdk to path third_party/bouffalolab/repo_bouffalo_sdk * update bouffalolab workflows build jobs --------- Co-authored-by: Restyled.io <commits@restyled.io>
… buildx build` (#43329) Signed-off-by: Maciej Grela <m.grela@samsung.com>
* Start adding bridged device basic information cluster files. * Restyle * Fix typo. * Typo * Fix one more typo. * Update cluster exclusions from using STL. * Fix gcc compile (hopefully) * More check-includes centralization. * More exclude cleanup. * Delete one more redundant line. * Add support for configuration version and node label changes. * Merge TestTLV fixes. * Update to match latest fixes to TLV reading. * Fix typo. * Fix nullptr charspan into string. * Fix license blurb. * Restyle * Update compare logic to accept embedded nulls (even if unlikely ....) * Fix compile. * Convert using data&length (will support embedded nulls ... oddly enough); * Restyle * Remove extra includes. * Add range check for timeoutMs. * Add ability to update "parent device configuration" which would generally go to the root device. * Update src/app/clusters/basic-information/VersionedConfigurationDelegate.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rename VersionedConfigurationDelegate.h to ConfigurationVersionDelegate.h * Better size detection. * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceIcdDelegate.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Report errors from IncreaseConfigurationVersion * Add better API for ICDs: make the cluster maintain pending active state. * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.cpp Co-authored-by: Shubham Patil <shubham.patil@espressif.com> * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.cpp Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Another bugfix. * Add a test. * More tests. * Clean up some tests. * More tests and one fix for completeness. * Slight doc update and a few more trivial tests * Some cleanup. * Remove one more unused header. * More header include fixes * Restyle * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Add bridged cluster also to libCHIP as it is decoupled. * Separate out the configuration version increase, so that code can be LTOed * Restyle * Use the new API in all-clusters * Do not allow event generation outside "normal" operation. * Add better label change and storage handling * Restyle and update docs * Move around the version delegate * A bit of cleanup * A bit better API * Fix rotating device id * Restyle * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Some review updates * Doc updates * remove stray // * Update src/app/clusters/bridged-device-basic-information-server/BridgedDeviceBasicInformationCluster.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Fix include and a stray include by chance --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Shubham Patil <shubham.patil@espressif.com>
…#43331) When SetUnmountedState returns false (failure), returning CHIP_NO_ERROR incorrectly signals success to the caller. Changed return value to CHIP_ERROR_INTERNAL for kForceUnmountedState and kClearUnmountedState cases to properly propagate the failure. Related: #43323
silabs-matter-ci-bot
bot
force-pushed
the
automation/update_main
branch
2 times, most recently
from
9eb896d to
8376e55
Compare
…cast cluster (#43333) * Add OnGroupModified call back for GroupDataProvider listeners. Update groupcastcluster to use the TimerDelegate and use it to report Membership changes. enable some gcast python test in ci. Update groupcast unit test to use timerDelegate rather than systemlayer directly * Addres comments. Improve UpdateGroupKey by returning early if group id is invalid to avoid key manipulation. Fix TC_GCAST_2_7 test script. Enable more GCAST test in ci * Restyled by prettier-yaml * Address comment, Fix ESP build. Fix flakiness in TC_GCAST_2.8 * Must disable TC_GCAST_2_2 in ci due to report chunking not being enable. * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Excluding Darwin from this as well * Also removing this from tests * Exclusion rather than inclusion, makes for easier editing * Restyled by gn --------- Co-authored-by: Restyled.io <commits@restyled.io>
silabs-matter-ci-bot
bot
force-pushed
the
automation/update_main
branch
from
9fddd9c to
7825b4c
Compare
… 5 (#43335) * Allow chip_automation_logging to be enabled from config when logging level is >= 5 * chip automation logging may be needed from in some components (e.g BdxMessages.cpp) Signed-off-by: Andrei Menzopol <andrei.menzopol@nxp.com>
CID: 47900366 Uninitialized scalar field. Here a private member "mOffset" has uninitialize risk. Which may results system hang. Conside below scenario: ``` MockClock clock; Microseconds64 time; clock.GetClock_RealTime(time); ``` System maybe crash due to garbage value in "mOffset". This patch fixes this risk by initializing menber variables in the construstor. Change-Id: I2f27b31bdb67f41bbce081f63041fd3dab3865d3 Reviewed-on: http://androidsource.nxp.com/project/31128 Reviewed-by: Ji Luo <ji.luo@nxp.com> Signed-off-by: Maximus <maximus.sun@nxp.com>
silabs-matter-ci-bot
bot
force-pushed
the
automation/update_main
branch
3 times, most recently
from
2473e77 to
0b34fde
Compare
Junior Martinez (jmartinez-silabs)
force-pushed
the
main
branch
from
00bb1da to
8f0d1d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR syncs the csa branch with the main branch.
PR MUST BE MERGED WITH MERGE COMMIT - ADMIN MUST ENABLE THE OPTION