Fix --without with slcp files#449
Open
Jean-Francois Penven (jepenven-silabs) wants to merge 1 commit intomainfrom
Open
Fix --without with slcp files#449Jean-Francois Penven (jepenven-silabs) wants to merge 1 commit intomainfrom
Jean-Francois Penven (jepenven-silabs) wants to merge 1 commit intomainfrom
Conversation
Jean-Francois Penven (jepenven-silabs)
requested a review
from a team
as a code owner
| APP_WITHOUT_ARG=$(build_without_arg "$WITHOUT_APP_COMPONENTS") | ||
| # Generate .slcp projects | ||
| run_slc_generate_with_retry generate -d $OUTPUT_DIR $PROJECT_FLAG $SILABS_APP_PATH --with $SILABS_BOARD $CONFIG_ARGS --generator-timeout=3500 -o makefile | ||
| run_slc_generate_with_retry generate -d "$OUTPUT_DIR" --sdk-package-path "$SISDK_ROOT" --sdk-package-path "$EXTENSION_DIR" --sdk-package-path "$WISECONNECT3_DIR" $PROJECT_FLAG "$SILABS_APP_PATH" $APP_WITH_ARG $APP_WITHOUT_ARG $CONFIG_ARGS --generator-timeout=180 -o makefile |
Contributor
There was a problem hiding this comment.
The build systems on main(SLC spec 12) vs release_2.8 (SLC spec 14) branches are different,
The above changes show use of --sdk-package-path, is a slc spec 14 feature.
Perhaps update PR to target release_2.8?
Contributor
Author
There was a problem hiding this comment.
Goal is to merge this PR on main so that future work will have this fix. If we need to wait for main to be on part with release_2.8 then we can wait. But I don't see why future development should target a previous release branch...
Contributor
There was a problem hiding this comment.
Agreed, then it should be good to go after the merge of release_2.8-1.5 back to main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
--without doesn't work if you're building a slcp file with the build.sh script. It does work if you're building a solution,
Description of Problem/Feature:
Description of Fix/Solution:
Copy paste the logic for solution (slcw ) with the slcp use case
Testing Done:
It did build locally with the release branch should work with this one as well