[Draft] Get static ZAP content from zzz_generated/#215
Draft
Sergei Lissianoi (selissia) wants to merge 4 commits intorelease_2.8-1.5from
Draft
[Draft] Get static ZAP content from zzz_generated/#215Sergei Lissianoi (selissia) wants to merge 4 commits intorelease_2.8-1.5from
Sergei Lissianoi (selissia) wants to merge 4 commits intorelease_2.8-1.5from
Conversation
| "path": "../../../third_party/matter_sdk/src/app/zap-templates/templates/app/clusters-shared-Global-Ids.h.zapt", | ||
| "name": "Shared global ids", | ||
| "output": "clusters/shared/GlobalIds.h" | ||
| }, |
Contributor
Author
There was a problem hiding this comment.
Once ZAP changes are in, these templates will be restored with an added "static" key which will prevent their execution unless "static" is set the .zap file.
| include: | ||
| - path: third_party/matter_sdk/zzz_generated/app-common/ | ||
| unless: [matter_zap_custom_generation] | ||
| - path: third_party/matter_sdk/zzz_generated/app-common/clusters/AccessControl |
Contributor
There was a problem hiding this comment.
This will add all the include paths in the Makefile, causing the issue pop up again if I am not wrong.
This should be provided below and having only one folder path, will confirm once.
Sergei Lissianoi (selissia)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
N/A
Description of Problem/Feature:
We should not generate static ZAP content in every project build. https://jira.silabs.com/browse/MATTER-5569
Description of Fix/Solution:
Update Matter components to pick up the static ZAP content from matter_sdk/zzz_generated rather than from the dynamically generated auotgen/zap_generated/clusters/.. directory tree. The exception is the case where the project uses custom clusters or cluster extensions: in this case the project must install the matter_zap_custom_generation component introduced in this PR and static ZAP content will be generated and picked up from auotgen/zap_generated/clusters/...
Introduce the gen_static_zap_includes.py which syncs the components with changes to zzz_generated, the script should be run with every CSA merge.
Depends on project-chip/zap#1674
Testing Done: