Use absolute path construction in _process_slce_extra default parameter#177
Merged
sarthak shaha (Sarthak-Shaha) merged 2 commits intopkgmgr/upload_packagefrom Nov 4, 2025
Merged
Conversation
Co-authored-by: Sarthak-Shaha <130495524+Sarthak-Shaha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update artifactory upload package based on review feedback
Use absolute path construction in _process_slce_extra default parameter
Nov 4, 2025
Rehan Rasool (rerasool)
pushed a commit
to rerasool/matter_extension
that referenced
this pull request
Nov 7, 2025
Merge in WMN_TOOLS/matter_extension from disable_compiler_error_flags to release_2.5-1.4
Squashed commit of the following:
commit 2f5fd202dffe005fcf0cab9cc618a50531b20fb5
Author: Junior Martinez <67972863+jmartinez-silabs@users.noreply.github.com>
Date: Wed Nov 20 17:07:25 2024 -0500
add no-unused-parameter flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from #166 to ensure
_process_slce_extraconstructs paths relative toself.repo_rootregardless of execution context.Changes
filename: str = "packages/matter/matter.slce.extra"tofilename: Optional[str] = Noneos.path.join(self.repo_root, "packages/matter/matter.slce.extra")when no filename providedself.repo_root)This eliminates ambiguity around relative path resolution and makes the path construction explicit and deterministic.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.