Skip to content

Pkgmgr/public repo#174

Draft
sarthak shaha (Sarthak-Shaha) wants to merge 32 commits intomainfrom
pkgmgr/public_repo
Draft

Pkgmgr/public repo#174
sarthak shaha (Sarthak-Shaha) wants to merge 32 commits intomainfrom
pkgmgr/public_repo

Conversation

@Sarthak-Shaha
Copy link
Contributor

@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) commented Oct 31, 2025

Issue Link:

Description of Problem/Feature:

Description of Fix/Solution:

Testing Done:

silabs-ArghyaD and others added 26 commits October 31, 2025 09:59
@silabs-ArghyaD @Sarthak-Shaha
Pull request #577: MATTER-5289: Integrated wifisdk v4.0.0-ifc1fc
329ed69 
Merge in WMN_TOOLS/matter_extension from integration/sisdk_v2025.12.0_wifisdk_v4.0.0_ifc1fc to integration/sdk-25q4

Squashed commit of the following:

commit 656650b691874b6e7cf5110d3919926e9ff9ee75
Author: ardutta <arghya.dutta@silabs.com>
Date:   Wed Aug 6 10:53:17 2025 +0530

    Updated matter private pointer after PR merge

commit 45e2f90ed7535b94ba332158fb42895dc4d68b35
Author: ardutta <arghya.dutta@silabs.com>
Date:   Tue Aug 5 10:57:25 2025 +0530

    Changed wifi sdk pointer

commit 25a4705b32791c481e472a1be7c658442d31bec6
Author: ardutta <arghya.dutta@silabs.com>
Date:   Tue Aug 5 10:32:26 2025 +0530

    Updated matter private pointer and changed submodule link to github

commit c4bac780a4cb982c8423263129cccee6a85548d7
Author: ardutta <arghya.dutta@silabs.com>
Date:   Mon Aug 4 14:51:30 2025 +0530

    Removed sisdk integration due to pipeline failure

commit fab4665b3f71f930d0f62a5bde465d3d882c77ce
Author: ardutta <arghya.dutta@silabs.com>
Date:   Fri Aug 1 16:24:49 2025 +0530

    Changed matter private pointer

commit 80e4afab8496bd97afec4d7be490a862422ac58c
Author: ardutta <arghya.dutta@silabs.com>
Date:   Mon Jul 28 10:30:00 2025 +0530

    Matter private pointer change

commit 9184d59153291aea0fff24855677b521f1ea5847
Author: ardutta <arghya.dutta@silabs.com>
Date:   Fri Jul 25 12:37:23 2025 +0530

    Updated wifisdk links to stash

commit 4b691522fea50a8e7c04c72140f1edc03065fb0c
Author: ardutta <arghya.dutta@silabs.com>
Date:   Thu Jul 24 17:32:46 2025 +0530

    MATTER-5289: Integrated sisdk v2025.12.0-ifc1fc and sisdk v4.0.0-ifc1fc
@silabs-ArghyaD @Sarthak-Shaha
Pull request #619: MATTER-5420: Update WiseConnect3 SDK v4.0.0-ifc2fc…
8fddfc5 
… and Simplicity SDK v2025.12.0-ifc2rc2

Merge in WMN_TOOLS/matter_extension from update/wiseconnect-v4.0.0-ifc2fc to integration/sdk-25q4

Squashed commit of the following:

commit b584405b2931cd02fdb6a2a814af52bdb8d302d3
Author: ardutta <arghya.dutta@silabs.com>
Date:   Thu Sep 11 14:05:33 2025 +0530

    Updated the matter private pointer after PR merge

commit d20bffea6649592d031ed878751d903817cff29b
Author: ardutta <arghya.dutta@silabs.com>
Date:   Thu Sep 11 10:35:40 2025 +0530

    Updated matter support pointer

commit 46741b321a3eabe44c7355050c49b001fc55912e
Author: Arghya Dutta <ardutta@silabs.com>
Date:   Wed Sep 10 21:17:17 2025 +0530

    Updated matter sdk pointer

commit 3c7a9692dd4e9888e79f80362961836066bbf44c
Author: ardutta <arghya.dutta@silabs.com>
Date:   Tue Sep 9 15:20:50 2025 +0530

    Updated upgrade rule for wiseconnect_common component

commit f0a426f327adf63c3b1438bcccd4f06cffe2a46d
Author: ardutta <arghya.dutta@silabs.com>
Date:   Tue Sep 9 09:43:19 2025 +0530

    Updated SiSDK pointer

commit 0b6e6827e29634265c02ffc720470662aa13e832
Author: ardutta <arghya.dutta@silabs.com>
Date:   Mon Sep 8 16:19:18 2025 +0530

    Updated SiSDK pointer to v2025.12.0-ifc2rc2

commit 2bc976d81b242cb3383b3c4c862c00440591ba81
Author: ardutta <arghya.dutta@silabs.com>
Date:   Wed Sep 3 15:16:02 2025 +0530

    Updated sisdk url to stash as it's an internal release

commit 0250c84161ab1b888e1d950d1dc8b1002d8d274f
Author: ardutta <arghya.dutta@silabs.com>
Date:   Wed Sep 3 13:51:39 2025 +0530

    Updated gitmodules for SiSDK v2025.12.0-ifc1fc

commit df017d145229e0939e214013b8383ba601dd5039
Author: ardutta <arghya.dutta@silabs.com>
Date:   Wed Sep 3 10:56:44 2025 +0530

    Updated sisdk pointer for v2025.12.0-ifc1fc

commit 47f1dc69a43391ade51352225843995ce5dbfca2
Author: ardutta <arghya.dutta@silabs.com>
Date:   Tue Sep 2 12:01:49 2025 +0530

    Updated the wiseconnect_sdk component in sample apps

commit ffb94ecf52944699d1a07ed8da40abc2272dab8c
Author: ardutta <arghya.dutta@silabs.com>
Date:   Tue Sep 2 09:42:00 2025 +0530

    MATTER-5420: Update WiseConnect3 SDK v4.0.0-ifc2fc

commit ae60328532459f48a883f10b2582fca4f28b72fe
Author: Arghya Dutta <Arghya.Dutta@silabs.com>
Date:   Wed Aug 6 08:35:14 2025 +0000

    Pull request #577: MATTER-5289: Integrated wifisdk v4.0.0-ifc1fc

    Merge in WMN_TOOLS/matter_extension from integration/sisdk_v2025.12.0_wifisdk_v4.0.0_ifc1fc to integration/sdk-25q4

    Squashed commit of the following:

    commit 656650b691874b6e7cf5110d3919926e9ff9ee75
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Wed Aug 6 10:53:17 2025 +0530

        Updated matter private pointer after PR merge

    commit 45e2f90ed7535b94ba332158fb42895dc4d68b35
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Tue Aug 5 10:57:25 2025 +0530

        Changed wifi sdk pointer

    commit 25a4705b32791c481e472a1be7c658442d31bec6
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Tue Aug 5 10:32:26 2025 +0530

        Updated matter private pointer and changed submodule link to github

    commit c4bac780a4cb982c8423263129cccee6a85548d7
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Mon Aug 4 14:51:30 2025 +0530

        Removed sisdk integration due to pipeline failure

    commit fab4665b3f71f930d0f62a5bde465d3d882c77ce
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Fri Aug 1 16:24:49 2025 +0530

        Changed matter private pointer

    commit 80e4afab8496bd97afec4d7be490a862422ac58c
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Mon Jul 28 10:30:00 2025 +0530

        Matter private pointer change

    commit 9184d59153291aea0fff24855677b521f1ea5847
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Fri Jul 25 12:37:23 2025 +0530

        Updated wifisdk links to stash

    commit 4b691522fea50a8e7c04c72140f1edc03065fb0c
    Author: ardutta <arghya.dutta@silabs.com>
    Date:   Thu Jul 24 17:32:46 2025 +0530

        MATTER-5289: Integrated sisdk v2025.12.0-ifc1fc and sisdk v4.0.0-ifc1fc
@Sarthak-Shaha
This commit combines all the work from implementing package manager
00e4094 
GitHub Actions integration including:

- GitHub Actions workflows for building and uploading packages
- Conan package management configuration
- Build system improvements and package.slt files
- CI/CD pipeline enhancements
- Various bug fixes and improvements
- bootloader series 3 support
@Sarthak-Shaha
update slce.extra
b9f5868
@Sarthak-Shaha
series-3 support
223fdc4
@Sarthak-Shaha
rebase
36296d7
@Sarthak-Shaha
rebase
cbf2635
@Sarthak-Shaha
fix build.py
1a07ee0
@Sarthak-Shaha
fix build.py
992275d
@Sarthak-Shaha
create lockfile
95e0e3d
@Sarthak-Shaha
fix pkg.slt
aa81bc7
@Sarthak-Shaha
fix rebase
4744987
@Sarthak-Shaha
lockfile path fix
d0f5f7f
@Sarthak-Shaha
get version from slce
99f641f
@Sarthak-Shaha
use version from generate metadata
f8ec516
@Sarthak-Shaha
remove legacy support
4793ce6
@Sarthak-Shaha
use stable slt
71000ed
@Sarthak-Shaha
install matter as well
225a4d2
@Sarthak-Shaha
install matter as well
9eb488d
@Sarthak-Shaha
unpin dependencies
9f97612
@Sarthak-Shaha
minor fix
89c7978
@Sarthak-Shaha
fix merge conflicts
d962dc0
@Sarthak-Shaha
unpin dependencies
7cc54b0
@Sarthak-Shaha
unpin dependencies
ef8e9f9
@Sarthak-Shaha
testing remote
4650ea5
@Sarthak-Shaha
use public runners
57ece01
Copilot AI review requested due to automatic review settings October 31, 2025 18:00
@Sarthak-Shaha sarthak shaha (Sarthak-Shaha) marked this pull request as draft October 31, 2025 18:00
Copilot AI reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive migration to a package manager system for the Matter extension, updating from a hardcoded version system to a more flexible dependency management approach using Conan packages. The PR introduces public repository support, updates package configurations, and modernizes build workflows.

Key changes:

  • Migration from hardcoded matter_package_version file to dynamic version resolution from matter.slce
  • Replacement of extension references with direct component IDs for WiFi SDK components
  • Introduction of grouped dependency management with platform-specific versions (thread/wifi/common)

Reviewed Changes

Copilot reviewed 91 out of 94 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
slc/stage_extension.py Removes unnecessary file existence check in copy operation
slc/script/verify_vendor_silabs.py Updates method name from verify_vendor_silabs_file to verify_file
slc/script/verify_package_matter.py Refactors file writing to use inline code instead of helper function
slc/script/generate_pkg_slt.py Major refactor for grouped dependency management and matter.slce version resolution
slc/script/dependency_versions.yaml Restructures to grouped format with thread/wifi/common sections
Multiple .slcp files Removes wiseconnect3_sdk extension references and replaces with direct component usage
Workflow files Updates CI/CD configurations for new package management system
Package management files Introduces new package structure with matter/matter_app separation
Comments suppressed due to low confidence (1)

slc/script/generate_pkg_slt.py:1

  • [nitpick] Missing space in 'installer ="conan"' - should be 'installer="conan"' for consistency.
#!/usr/bin/env python3

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

slc/build.py
if i + 1 >= len(raw_extras):
sys.exit("--with requires a value")
with_options = raw_extras[i + 1]
print("with options = ",with_options)
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug print statement should be removed or replaced with proper logging using the logger.

Suggested change
print("with options = ",with_options)
logger.debug("with options = %s", with_options)

Copilot uses AI. Check for mistakes.
slc/script/generate_pkg_slt.py
for name, ver in merged.items():
if name == "matter":
continue
lines.append(f"{name} = {{ version = \"{ver}\", installer =\"conan\", prerelease=true }}\n")
Copy link

Copilot AI Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Missing space in 'installer ="conan"' - should be 'installer="conan"' for consistency.

Suggested change
lines.append(f"{name} = {{ version = \"{ver}\", installer =\"conan\", prerelease=true }}\n")
lines.append(f"{name} = {{ version = \"{ver}\", installer = \"conan\", prerelease=true }}\n")

Copilot uses AI. Check for mistakes.
Rehan Rasool (rerasool) pushed a commit to rerasool/matter_extension that referenced this pull request Nov 7, 2025
@mkardous-silabs
Pull request SiliconLabsSoftware#174: Update Wi-Fi components to pull…
8a98edb 
… in the Wi-Fi interface refactor

Merge in WMN_TOOLS/matter_extension from feature/update_matter_sdk to release_2.5-1.4

Squashed commit of the following:

commit 50414c55aa52a59519e4f4fa88e74e3b927d2715
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 17:45:49 2024 -0500

    fix syntaxe

commit 20803cd9a9d7cf984686ce2a942239b3d8885bd3
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 17:15:23 2024 -0500

    add missing recommends

commit 228193e35ba49bb99a220263f58c52c42ec62137
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 17:13:14 2024 -0500

    fix include path

commit 661b866c968438d79624a2bc55e4bc46cb06bc50
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 16:34:22 2024 -0500

    try to fix copy contents

commit b85a09ac36b718479d145ca8cda1f38d07fa659f
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 16:01:01 2024 -0500

    Continue to fix copy contents

commit f80d5ab5f9be5171fac740a67b562f6034603872
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 11:59:08 2024 -0500

    Fix copy contents - remove wfx_rsi.h

commit 38752dce807d4ab3b3c490bee9e928942d13ac06
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 11:10:23 2024 -0500

    fix 917Soc dishwasher and onoff plug

commit c1375b2fa657010e539095a1e47f6ba928eb7b47
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 10:25:05 2024 -0500

    remove efx32_ncp_host.c since it requires 917 specific files

commit 8d0e3f294d6d3c164bcee1e90032c10370de49e1
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 10:23:49 2024 -0500

    fix indentation

commit cc9a45d24e557c188ef329b578a0ca8701fc1624
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 09:49:04 2024 -0500

    Add efx32_ncp_host.c to the rs911x and Siwx917 ncp components

commit fde643d2a82db8ceb162b524e92c0029ce3ea0df
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 09:40:51 2024 -0500

    Fix 917 NCP builds

commit 75fe8b8f57c838480690163fb4cff9fe269b1084
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Mon Nov 18 08:37:51 2024 -0500

    address review comments

commit 857fa59dd37b078e4cee5588ddb87482f3a34b15
Author: Sergei Lissianoi <Sergei.Lissianoi@silabs.com>
Date:   Mon Nov 18 00:23:42 2024 +0000

    Applied suggestion

commit 714a1e573350e620139a0463eda457099bb30e95
Author: Sergei Lissianoi <Sergei.Lissianoi@silabs.com>
Date:   Mon Nov 18 00:23:36 2024 +0000

    Applied suggestion

commit 9f7b438c4589afd1a7a7f586d4b5a81aea342734
Author: Sergei Lissianoi <Sergei.Lissianoi@silabs.com>
Date:   Mon Nov 18 00:23:28 2024 +0000

    Applied suggestion

commit ffdfa8fe40b06c893935b1819e8cd66591151a0b
Author: Sergei Lissianoi <Sergei.Lissianoi@silabs.com>
Date:   Mon Nov 18 00:23:21 2024 +0000

    Applied suggestion

commit e9f2283023dc0b5e28e1cafa3555d75281f13673
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Sun Nov 17 19:22:13 2024 -0500

    Update submodule with correct reference

commit 36d6f88d863eda5b6eb1928fdcb752699edd18f1
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Sat Nov 16 16:56:51 2024 -0500

    Add missing provide to 917 ncp component

commit a0bf69b729ad2ce82c09fe01fba2a572554b61c7
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Sat Nov 16 16:53:27 2024 -0500

    Update 917 ncp component

commit 728999f7ea49a5bfbb2c89f33e6d4c306d4da8af
Author: Mathieu Kardous <mathieu.kardous@silabs.com>
Date:   Sat Nov 16 12:56:41 2024 -0500

    update submodules

... and 14 more commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sarthak-Shaha @silabs-ArghyaD