Skip to content

lang: detect ini file encoding #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
goto-bus-stop wants to merge 7 commits into
base: default
Choose a base branch
from
Open

lang: detect ini file encoding #12

goto-bus-stop wants to merge 7 commits into from

Conversation

@goto-bus-stop
Copy link
Member

@goto-bus-stop goto-bus-stop commented Aug 2, 2019 •
edited
Loading

INI files use the machine's local encoding by default, similarly to AoC itself. This patch detects the encoding of these files using the chardet crate.

TODO:

  • Detect the encoding over the entire file instead of line-by-line; at the moment, the test fails because one line is detected as a Thai encoding

@goto-bus-stop goto-bus-stop changed the base branch from master to default August 4, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@goto-bus-stop