Dev #152
Merged
Dev #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript and visual scriting
…S at 50hz and all button presses.
…eature/sdk-improvements
…stVR/BanterSDK into feature/sdk-improvements
Introduces UIElementResolverHelper to resolve element names to registered IDs across all panels, replacing the previous GetElementIdByName node. Updates all UI event and registration nodes to support both element ID and name inputs, prioritizing ID when provided. Removes obsolete GetElementIdByName implementation and integrates the new resolver for consistent element identification in visual scripting.
Introduced new Visual Scripting event nodes for dropdown, int field, slider, text field, and toggle changes. Extended OnUIEvent to support detailed outputs for mouse, keyboard, and value change events. Updated LoadingCage.mat to use new dissolve guide texture.
Replaces the hardcoded worldSpaceSize value with the resolution field in BanterUIPanel, allowing dynamic sizing based on the configured resolution. Also removes HideInInspector from the resolution field to make it visible in the inspector.
…stVR/BanterSDK into feature/sdk-improvements
…r Min Max) Introduces Visual Scripting event units for MinMaxSlider, RadioButton, RadioButtonGroup, and SliderInt UI controls. Updates UIElementBridge to support registration, unregistration, and event dispatch for these controls, including handling of int and Vector2 change events and mouse events.
…stVR/BanterSDK into feature/sdk-improvements
Introduces UIEventAutoRegisterHelper and CoroutineRunner to support automatic event registration with retry logic for UI elements in Visual Scripting nodes. Adds an 'Auto Register' input to all relevant event nodes, updates their StartListening methods to use the helper, and improves logging and element resolution for debugging. Also enhances UIElementBridge and UIElementResolver with additional debug output for event registration and element resolution.
Updated all UI event units to use 'Events\Banter\UI' as their category, removing subcategories like Input, Mouse, and Keyboard for consistency. Deleted the generic OnUIEvent unit and its meta file, likely to favor more specific event units.
…into feature/ora
…into feature/ora
…into feature/ora
Feature/ora
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughComprehensive SDK expansion integrating Ora WebRTC support, restructuring core messaging pipelines, adding asset management systems, expanding UI frameworks, introducing extensive editor inspector customizations, and documenting public JavaScript APIs. Includes shell utilities for avatar screenshots, metadata cleanup across project assets, and new configuration models for command routing and asset types. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (284)
Comment |
GarethIW
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes
New Features
Improvements
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.