This repository was archived by the owner on Jul 3, 2025. It is now read-only.
Create ConsensusBlocksGet response #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisSchinnerl
force-pushed
the
chris/get-blocks
branch
from
648613d to
69ed889
Compare
ChrisSchinnerl
force-pushed
the
chris/get-blocks
branch
from
d55b539 to
ad67d02
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement the TODO in
handleGETConsensusBlocksNOTE: I haven't compared that to an actual output yet. It was actually a lot more annoying than expected cause some of the legacy types only differ from the core type in the json field names. Definitely should double-check that all of those match.