Skip to content
This repository was archived by the owner on Jul 3, 2025. It is now read-only.

initial commit #170

Draft
n8mgr wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

initial commit #170

n8mgr wants to merge 13 commits into from

Conversation

@n8mgr
Copy link
Member

@n8mgr n8mgr commented Apr 30, 2025 •
edited
Loading

Provide a v2 compatible API bridge for the old said API using a combination of walletd and vaultd.

Goals

  • renter, host, explorer, miner endpoints are unnecessary
  • Existing endpoints should have the same request and response format.
  • Endpoints that can support V2 implicitly should
  • The few v2 endpoints we need to add should have a similar "feel"

@github-project-automation github-project-automation bot moved this to In Progress in Sia Apr 30, 2025
@n8mgr
Copy link
Member Author

n8mgr commented Apr 30, 2025 •
edited
Loading

@ChrisSchinnerl @peterjan @lukechampine prs are welcome 😛

@lukechampine
Copy link
Member

lukechampine commented May 1, 2025

seems wrong for this to be on master. 🤔 Or, at least, current master should move to a different permanent branch, e.g. v1.

@n8mgr
Copy link
Member Author

n8mgr commented May 1, 2025 •
edited
Loading

seems wrong for this to be on master. 🤔 Or, at least, current master should move to a different permanent branch, e.g. v1.

I'm fine with eventually setting v2 to be the default branch rather than merging this to master, creating a v1 for existing master, or just leaving it all as is and publishing v2 releases while not touching the branches. Don't really feel strongly.

ChrisSchinnerl
ChrisSchinnerl reviewed May 2, 2025
View reviewed changes
api/api.go
BlockFrequency: uint64(cs.Network.BlockInterval.Seconds()),

MaturityDelay: cs.Network.MaturityDelay,
SiafundCount: types.NewCurrency(10000, 0),
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl May 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SiafundCount: types.NewCurrency(10000, 0),
SiafundCount: types.NewCurrency64(10000),

@ChrisSchinnerl
Copy link
Member

ChrisSchinnerl commented May 2, 2025

This diff is melting my browser

@ChrisSchinnerl
Create ConsensusBlocksGet response (#171)
ffedefb 
* create consensus blocks get response

* implement conversion functions

* add docstrings

* populate response

* cleanup

* fix linting
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

Sia
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@n8mgr @lukechampine @ChrisSchinnerl