Skip to content

Push version to v3#23

Closed
ChrisSchinnerl wants to merge 9 commits intomasterfrom
chris/v2
Closed

Push version to v3#23
ChrisSchinnerl wants to merge 9 commits intomasterfrom
chris/v2

Conversation

@ChrisSchinnerl
Copy link
Member

@ChrisSchinnerl ChrisSchinnerl commented Dec 15, 2025

With #22 being a breaking change we should add the v3 suffix before tagging v3.0.0.

Depends on #27

@ChrisSchinnerl ChrisSchinnerl self-assigned this Dec 15, 2025
@ChrisSchinnerl ChrisSchinnerl requested a review from n8mgr December 15, 2025 15:03
@ChrisSchinnerl ChrisSchinnerl marked this pull request as ready for review December 15, 2025 15:03
Copilot AI review requested due to automatic review settings December 15, 2025 15:03
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the mux module to v2 by adding the /v2 suffix to the module path, which is required for semantic versioning in Go when releasing a breaking change (as mentioned in the referenced PR #22).

Key Changes:

  • Updated module declaration to use the v2 path
  • Updated internal import to reference the v3 protocol implementation under the new v2 module path

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
go.mod Updates the module declaration from go.sia.tech/mux to go.sia.tech/mux/v2 to support semantic versioning for the upcoming v2.0.0 release
mux.go Updates the import path for the v3 protocol implementation to go.sia.tech/mux/v2/v3 to reflect the new v2 module structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mux.go Outdated
"time"

muxv3 "go.sia.tech/mux/v3"
muxv3 "go.sia.tech/mux/v2/v3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely one of the import paths of all time

maybe we should lift v3 into the top-level, and push the version to v3?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds like the best idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lifted it and also added a little bonus in my latest commit to make the handshake more efficient.

@ChrisSchinnerl ChrisSchinnerl changed the title Push version to v2 Push version to v3 Dec 16, 2025
@lukechampine
Copy link
Member

should we go ahead and drop covert streams in v3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants