Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Pull request overview
This PR migrates the mux module to v2 by adding the /v2 suffix to the module path, which is required for semantic versioning in Go when releasing a breaking change (as mentioned in the referenced PR #22).
Key Changes:
- Updated module declaration to use the v2 path
- Updated internal import to reference the v3 protocol implementation under the new v2 module path
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go.mod | Updates the module declaration from go.sia.tech/mux to go.sia.tech/mux/v2 to support semantic versioning for the upcoming v2.0.0 release |
| mux.go | Updates the import path for the v3 protocol implementation to go.sia.tech/mux/v2/v3 to reflect the new v2 module structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
70aa2f6 to
62b1cfd
Compare
mux.go
Outdated
| "time" | ||
|
|
||
| muxv3 "go.sia.tech/mux/v3" | ||
| muxv3 "go.sia.tech/mux/v2/v3" |
There was a problem hiding this comment.
definitely one of the import paths of all time
maybe we should lift v3 into the top-level, and push the version to v3?
There was a problem hiding this comment.
Lifted it and also added a little bonus in my latest commit to make the handshake more efficient.
f5252f5 to
f0c7f7f
Compare
f0c7f7f to
f09049c
Compare
a1f458a to
49e662d
Compare
5a81753 to
e253404
Compare
cb4c7a0 to
76ea321
Compare
|
should we go ahead and drop covert streams in v3? |
With #22 being a breaking change we should add the
v3suffix before taggingv3.0.0.Depends on #27