Skip to content

Conversation

@ChrisSchinnerl
Copy link
Member

Leaving it up to the user tot vacuum it if they want.

Setting it to -1 theoretically means it will go as fast as it can using the sqlite3 online backup API.

Closes #920

@ChrisSchinnerl ChrisSchinnerl requested a review from n8mgr February 4, 2026 17:16
@ChrisSchinnerl ChrisSchinnerl self-assigned this Feb 4, 2026
Copilot AI review requested due to automatic review settings February 4, 2026 17:16
@github-project-automation github-project-automation bot moved this to In Progress in Sia Feb 4, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bd9e604644

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR speeds up database backups by optimizing the SQLite backup process. It addresses issue #920 where backing up large databases (35GB+) was taking multiple days, making nightly backups impossible.

Changes:

  • Modified backup step size from 100 pages to -1 (unlimited) to copy the entire database in one operation
  • Removed the VACUUM operation from the backup process to save time, leaving it optional for users

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
persist/sqlite/store.go Modified backup process to use step size -1 and removed VACUUM operation for faster backups
.changeset/remove_backup_step_size_limit_and_dont_vacuum_backup_to_speed_it_up.md Added changeset documenting the performance improvements

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@n8mgr n8mgr merged commit ab8b364 into master Feb 4, 2026
19 checks passed
@n8mgr n8mgr deleted the chris/faster-backups branch February 4, 2026 19:36
@github-project-automation github-project-automation bot moved this from In Progress to Done in Sia Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Backing up hostd is no longer viable

2 participants