consensus: minor cleanup in validation_test.go #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #381 by cleaning up test cases in consensus/validation_test.go. The changes remove duplicate code and improve test clarity by making test descriptions more specific.
Changes:
- Removed duplicate test case for "storage proof 0 conflicts with previous proof"
- Updated test descriptions to distinguish between two different partial signature validation scenarios
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
chris124567
requested review from
Alrighttt,
ChrisSchinnerl,
lukechampine and
n8mgr
lukechampine
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #381
The third issue was no longer present.