Cap max storage per contract #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8mgr
requested review from
ChrisSchinnerl and
Copilot
and removed request for
Copilot
n8mgr
force-pushed
the
nate/cap-max-storage
branch
from
bfbefbf to
f76e763
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a temporary cap of 10 TiB per contract to replace the existing max collateral validation. The changes introduce a storage-based validation approach that will eventually become host-configurable.
Changes:
- Introduced a 10 TiB storage cap constant (
maxContractStorage) - Removed
maxCollateralparameter from validation functions in favor of storage-based limits - Added
requestedContractStoragehelper function to calculate storage from collateral or allowance - Updated
MinRenterAllowanceandMaxHostCollateralto respect the storage cap
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| rhp/v4/rhp.go | Added maxContractStorage constant, implemented requestedContractStorage function, and updated MinRenterAllowance/MaxHostCollateral to use storage caps |
| rhp/v4/validation.go | Removed maxCollateral parameters from three Validate methods and replaced collateral checks with storage-based validation |
| .changeset/capped_max_per_contract_storage_to_10tib.md | Changeset file documenting the major version change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
n8mgr
force-pushed
the
nate/cap-max-storage
branch
from
f76e763 to
42c0627
Compare
ChrisSchinnerl
requested changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a temporary cap of 10TiB per contract. This will eventually replace max collateral and be host configurable.