Open
Conversation
# Conflicts: # spy.log # src/main/java/com/shy_polarbear/server/global/common/constants/BusinessLogicConstants.java # src/main/java/com/shy_polarbear/server/global/exception/ExceptionStatus.java
Collaborator
|
혹시 월요일에 리뷰해도 될까요,,,,,,,?🐸🐔🐰 |
Member
Author
|
넵 졸업전시 이후에 반영할거라 천천히 해주세유🦧 |
0sunset0
reviewed
Nov 17, 2023
Collaborator
0sunset0
left a comment
0sunset0
left a comment
There was a problem hiding this comment.
어제 전시는 잘 하셨나요~ 늦어서 죄송합니다~~ 캐롤 들으면서 보니까 코드 잘 봤습니다🎄🎁
Comment on lines
+61
to
+62
| @OneToMany(mappedBy = "receiver") | ||
| private List<Notification> notificationList = new ArrayList<>(); |
Collaborator
There was a problem hiding this comment.
근데 '유저-알림' 관계를 양방향으로 하는 이유가 뭘까요??
확장성을 고려한 걸까요?
|
|
||
| // 내 알림 리스트 조회 | ||
| public List<NotificationResponse> getMyNotifications(Long userId) { | ||
| List<Notification> notificationList = notificationRepository.findAllByReceiverId(1L); |
| package com.shy_polarbear.server.domain.notification.model; | ||
|
|
||
| enum NotificationReceiverType { | ||
| COMMON, AUTHOR |
Collaborator
There was a problem hiding this comment.
알림 받는 사람이 왜 받는지 쉽게 알게 하려고 enum 만드신거 맞죠!?
| .post(RequestBody.create(message, MediaType.parse("application/json; charset=urf-8"))) | ||
| .build(); | ||
|
|
||
| try (Response response = okHttpClient.newCall(request).execute()) { |
Collaborator
There was a problem hiding this comment.
FirebaseMessaging.getInstance().sendAsync(fcmMessage).get();
이걸 사용할 수는 없는 건가요?? - fcm 잘 모르는 노을😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 요약
FCM 기능 구현했습니다..!
너무 늦었지만... 구현해둔게 아까워서 마무리했어요
조금 불안해서 졸업 전시 끝나고 머지하는게 좋을 것 같긴 합니다
🌱 작업한 내용
🌱 PR 포인트
📸 스크린샷
📮 관련 이슈