Conversation
Shuudy
force-pushed
the
feature/add-ponctual-rides
branch
from
8250114 to
a7f65f0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for punctual (one-time) ride proposals and rides, complementing the existing regular ride functionality. The implementation introduces a ride type classification system to differentiate between regular recurring rides and one-time punctual rides.
Key Changes:
- Added
ride_typecolumn to database schema for bothride_proposalsandridestables - Enhanced carpool matching to support punctual rides based on address proximity alone
- Updated UI to allow users to filter and create rides by type
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/schema.sql | Added ride_type column to ride_proposals and rides tables |
| src/main/resources/data.sql | Updated seed data to include ride type for existing proposals |
| src/main/java/com/kovoit/entity/RideProposal.java | Added rideType field and updated constructor |
| src/main/java/com/kovoit/entity/Ride.java | Added rideType field with getters/setters |
| src/main/java/com/kovoit/service/RideProposalService.java | Updated proposeRide method to accept ride type parameter |
| src/main/java/com/kovoit/service/RideService.java | Modified ride creation to preserve ride type from proposal |
| src/main/java/com/kovoit/service/CarpoolMatchingService.java | Added methods for punctual ride matching by address |
| src/main/java/com/kovoit/views/CarpoolView.java | Implemented ride type selection and conditional matching logic |
| src/main/java/com/kovoit/views/RideView.java | Added ride type column to rides grid |
| src/main/java/com/kovoit/views/RideProposalsView.java | Added ride type column to proposals grid |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Mizi00
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for creating punctual ride proposals and rides.