feat: add search functionality to CarpoolView for filtering student matches#12
Merged
feat: add search functionality to CarpoolView for filtering student matches#12
CarpoolView for filtering student matches#12Conversation
CarpoolView for filtering student matches
Mizi00
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the ability to search among
carpool suggestionsbyemailoraddressin theCarpoolView.Students can now filter compatible suggestions using a search field and a dedicated button, improving usability and making it easier to find relevant carpool partners.
Note
In the future, with the introduction of the
punctual ridesystem, thematchinglogic could be adjusted to ignore availabilities.Since a punctual ride represents an unusual or one-time trip, it would make sense to display the availabilities of the searched students even if they fall outside their current matching criteria.