This repository was archived by the owner on Jun 20, 2024. It is now read-only.
Add bracket closing rules #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macournoyer
approved these changes
Mar 10, 2021
Contributor
macournoyer
left a comment
macournoyer
left a comment
There was a problem hiding this comment.
LGTM! But I would remove the lineComment as it's not yet supported, and might even change.
language-configuration.json
Outdated
| @@ -0,0 +1,39 @@ | |||
| { | |||
| "comments": { | |||
| "lineComment": ["{% # ", "{%}"], | |||
Contributor
There was a problem hiding this comment.
This is not yet implemented. Will be once Shopify/liquid-c#144 is deployed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Demo video showcasing indentation rules + auto closing tags