Drop the benchmark dependency
#2407
Open
+10
−644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR. Can you fix typechecking errors? |
Earlopain
force-pushed
the
drop-benchmark-dep
branch
from
065a67c to
38e669c
Compare
Contributor
Author
|
Oops, yeah |
Member
|
We have addressed a few CI issues this week, which should make this PR's build green. Can you rebase the PR? Thx |
Earlopain
force-pushed
the
drop-benchmark-dep
branch
from
38e669c to
1b0f472
Compare
It is trivial, don't have to take on a dependency for that.
Earlopain
force-pushed
the
drop-benchmark-dep
branch
from
1b0f472 to
947c6f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
tapioca currently depends on the
benchmarkgem because of a change to Ruby bundled gems. The functionality is trivial though, and I don't think you have to take on a dependency for that.Implementation
Just use
Process.clock_gettimedirectly.Tests
No behaviour change. I just ran some cli commands and they still print the time in seconds. Probably the output is also already asserted against somewhere.