Skip to content

Extract gem and dsl loaders in a new API #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Morriar merged 3 commits into from
Jul 20, 2022
Merged

Extract gem and dsl loaders in a new API #1072

Morriar merged 3 commits into from
Jul 20, 2022

Conversation

@Morriar
Copy link
Contributor

@Morriar Morriar commented Jul 20, 2022

Motivation

This is some cleaning work ahead of a new implementation for #912.

Implementation

This splits the current runtime/loader into two separate loaders that inherit from Loaders::Loader so we can factorize some code.

Tests

See automated tests (no behavioral change).

Morriar and others added 3 commits July 20, 2022 15:53
@Morriar @paracycle
Extract DSL loader
b3fbbe4 
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar @paracycle
Rename compiler_path -> compilers_path
bce2cfb 
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar @paracycle
Extract gem loader
22a4324 
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Co-authored-by: Ufuk Kayserilioglu <ufuk.kayserilioglu@shopify.com>
@Morriar Morriar added the chore label Jul 20, 2022
@Morriar Morriar requested a review from a team as a code owner July 20, 2022 19:56
@Morriar Morriar merged commit d762b73 into main Jul 20, 2022
@Morriar Morriar deleted the new-loader branch July 20, 2022 22:40
@shopify-shipit shopify-shipit bot temporarily deployed to production August 31, 2022 14:40 Inactive
@jeffcarbs jeffcarbs mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KaanOzkan KaanOzkan KaanOzkan approved these changes

@vinistock vinistock vinistock approved these changes

Assignees

@paracycle paracycle

@Morriar Morriar

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Morriar @KaanOzkan @vinistock @paracycle