Skip to content

Fix test runner and output #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paracycle merged 1 commit into from
Jan 13, 2026
Merged

Fix test runner and output #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions bin/test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,16 @@
#!/usr/bin/env bash

if [[ 2 -eq $# ]]; then
bundle exec rake TEST="$1" TESTOPTS="-n='/$2/'"
elif [[ 1 -eq $# ]]; then
bundle exec rake TEST="$1"
else
bundle exec rake "$@"
fi
#!/usr/bin/env ruby
# frozen_string_literal: true

#
# This file was generated by Bundler.
#
# The application 'minitest' is installed as part of a gem, and
# this file is here to facilitate running it.
#

ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)

require "rubygems"
require "bundler/setup"

load Gem.bin_path("minitest", "minitest")
2 changes: 2 additions & 0 deletions test/test_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,5 +50,7 @@ def default_spoom_test_gemfile

require "minitest/autorun"
require "minitest/reporters"
require "minitest/minitest_reporter_plugin"
Minitest.register_plugin(:minitest_reporter)
Copy link
Contributor

@Morriar Morriar Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need the reporter?

Copy link
Member Author

@paracycle paracycle Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This is for registering Minitest Reporters' plugin to Minitest (which used to be automatic previously), but we still need to set the reporter, etc after that.

In the next release of minitest-reporters this should be done automatically inside the library. For now, we need to do it explicitly.

Copy link
Contributor

@Morriar Morriar Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, do we still need the reporter itself?

Copy link
Member Author

@paracycle paracycle Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, maybe not. Without the reporter, all you get is the dots for each test. I thought you wanted to keep the spec style reporting.

Copy link
Contributor

@Morriar Morriar Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's me being confused, since I saw just dots in the output before this PR, but indeed the output is much better with the reporter enabled 👍

Though, iirc it's a bit buggy with parallelism like in Tapioca?

Copy link
Member Author

@paracycle paracycle Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen this one be that buggy, tbh, we can always change it if it is.


Minitest::Reporters.use!(Minitest::Reporters::SpecReporter.new(color: true))