move git ask pass to env config #1441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-yc
force-pushed
the
simonyc/add-git-ask-pass-config
branch
2 times, most recently
from
af799d8 to
ec6a050
Compare
bbbriana
approved these changes
Nov 26, 2025
timothysmith0609
approved these changes
Dec 10, 2025
lib/shipit.rb
Outdated
| end | ||
|
|
||
| def use_git_askpass? | ||
| return @use_git_askpass unless @use_git_askpass.nil? |
Contributor
There was a problem hiding this comment.
It looks like this works as intended, but have you validated that @use_git_askpass is properly set as expected?
Contributor
Author
There was a problem hiding this comment.
In Shipit, I modified the development config and confirmed that:
- if
Shipit.use_git_askpass = false, the auth bug does not show. - if
Shipit.use_git_askpass = true, the auth bug does show. - if
Shipit.use_git_askpassis not defined, the auth bug does show (since we default to true as shown above).
I assume this is sufficient?
simon-yc
force-pushed
the
simonyc/add-git-ask-pass-config
branch
from
ec6a050 to
0394243
Compare
simon-yc
force-pushed
the
simonyc/add-git-ask-pass-config
branch
from
0394243 to
ceeba46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.