Add auth servers #58
Add auth servers #58
Conversation
|
@ltk @felipesaezreyes We could really use the new features that this PR would provide and we'd be interested in helping do whatever needs to be done to bring this into the gem. Thank you for your time. 😄 |
| http.authorization('SSWS ', @token) if @token | ||
| http.authorization(:Bearer, @access_token) if @access_token | ||
| http.headers[:authorization] = "SSWS #{@token}" if @token | ||
| http.headers[:authorization] = "Bearer #{@access_token}" if @access_token |
There was a problem hiding this comment.
Just asking, why is this change needed?
There was a problem hiding this comment.
Unsure why specifically this change was made but if I had to guess it was likely to make the application of the authorization header uniform with the how the other headers were being set above it. If this is a blocker we can likely revert this change without issue.
|
Changes here look good to me and consistent with how other methods to interact with Okta API are implemented. However, I do not have much knowledge about this repository and I would appreciate if other contributor can have a look too. |
4 participants
Reopening the auth server PR to hopefully get a valid CLA.
Implements functionality to interact with Authorization Servers and Policies using Oktakit.