Skip to content

replace empty literal for empty array #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
er1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

replace empty literal for empty array #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ext/liquid_c/parser.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
#include "usage.h"

static VALUE empty_string;
static VALUE frozen_empty_array;
static ID id_to_i, idEvaluate;

void init_parser(parser_t *p, const char *str, const char *end)
Expand Down Expand Up @@ -178,7 +179,7 @@ static VALUE try_parse_literal(parser_t *p)
break;
case 'e':
if (memcmp(str, "empty", size) == 0)
result = empty_string;
result = frozen_empty_array;
break;
}
break;
Expand Down Expand Up @@ -272,5 +273,9 @@ void liquid_define_parser(void)

empty_string = rb_utf8_str_new_literal("");
rb_global_variable(&empty_string);

frozen_empty_array = rb_ary_new();
rb_ary_freeze(frozen_empty_array);
rb_global_variable(&frozen_empty_array);
}

6 changes: 4 additions & 2 deletions test/unit/expression_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@ def test_constant_literals
assert_nil(Liquid::C::Expression.strict_parse('null'))

empty = Liquid::C::Expression.strict_parse('empty')
assert_equal('', empty)
assert_same(empty, Liquid::C::Expression.strict_parse('blank'))
assert_equal([], empty)

blank = Liquid::C::Expression.strict_parse('blank')
assert_equal('', blank)
end

def test_push_literals
Expand Down