Part 1: Bump base image to Node 20 and add ghcr.io build workflow#104
Merged
graygilmore merged 1 commit intomainfrom Apr 7, 2026
Merged
Part 1: Bump base image to Node 20 and add ghcr.io build workflow#104graygilmore merged 1 commit intomainfrom
graygilmore merged 1 commit intomainfrom
Conversation
Shopify CLI 3.93+ requires Node >=20.10.0 with engine-strict, which breaks the action's Node 18 base image (fixes #103). This is part 1 of 2 — it updates the base image recipe and adds a workflow to build/push it to ghcr.io. A follow-up PR will update the Dockerfile to reference the new ghcr.io image once it exists. Changes: - Dockerfile.base: node:18-buster -> node:20-bookworm (Buster reached EOL June 2024) - Dockerfile.base: Replace deprecated apt-key with signed-by keyring for Chrome repo - New workflow (build-base-image.yml): Builds and pushes the base image to ghcr.io/shopify/lighthouse-ci-action:3.0.0 on Dockerfile.base changes or manual dispatch Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
graygilmore
force-pushed
the
gg-ghcr-node20
branch
from
ddf7ce4 to
00359fe
Compare
graygilmore
changed the title
charlespwd
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #103 (part 1 of 2). Shopify CLI 3.93+ requires Node >=20.10.0 (
engine-strict: true), which breaks the action since the base Docker image uses Node 18.This PR updates the base image recipe and adds a CI workflow to build/push it to ghcr.io:
Dockerfile.basefromnode:18-bustertonode:20-bookworm(Buster reached EOL June 2024)apt-keyusage for the Chrome APT repo (required for Bookworm)build-base-image.ymlworkflow to build and push the base image toghcr.io/shopify/lighthouse-ci-action:3.0.0onDockerfile.basechanges or manual dispatchWhy ghcr.io?
The previous base image was hosted on a personal Docker Hub account (
cpclermont/lighthouse-ci-action) and hadn't been rebuilt since January 2024. Moving to ghcr.io means any repo maintainer can trigger a rebuild — the workflow usesGITHUB_TOKENautomatically.What's next
After this merges and the workflow pushes the
3.0.0image, a follow-up PR will update theDockerfileandMakefileto referenceghcr.io/shopify/lighthouse-ci-action:3.0.0.