Add e2e tests for discount codes #3427
Conversation
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
itsjustriley
force-pushed
the
E2E-Discount-code-functionality
branch
from
6ca9a08 to
44c2b83
Compare
kdaviduik
left a comment
kdaviduik
left a comment
There was a problem hiding this comment.
Needs a rebase to fix E2E tests in CI but other than that LGTM! :)
| await storefront.tryApplyDiscountCode(inactiveDiscountCode); | ||
|
|
||
| const appliedCodes = await storefront.getAppliedDiscountCodes(); | ||
| expect(appliedCodes).not.toContain(inactiveDiscountCode); |
There was a problem hiding this comment.
This verifies the code isn't applied, but doesn't verify that helpful feedback is shown to the user (which is indeed the case right now).
Since we're going to be fixing this soon, it would be great to add a TODO comment here for our future selves to add an assertion that an error message is displayed - this catches both functionality and UX regressions.
| }); | ||
|
|
||
| test('Applies discount via URL', async ({storefront}) => { | ||
| await storefront.goto(`/discount/${activeDiscountCode}`); |
There was a problem hiding this comment.
oooh i forgot this route even existed, nice catch
| @@ -0,0 +1,59 @@ | |||
| import {execSync} from 'node:child_process'; | |||
There was a problem hiding this comment.
CI looks like it's failing because this file isn't using the secrets properly. I've now merged this PR so if you rebase with main and keep my version of this file then things should work for you :)
3 participants
WHY are these changes introduced?
Closes developer-tools-team/issues/978
WHAT is this pull request doing?
Adds e2e tests for discount counts that verify:
HOW to test your changes?
Run tests (covered by CI)
Notes for Reviewers
Checklist