feat(e2e): add cart line item E2E test suite #3424
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comprehensive E2E tests for cart line item behavior in the skeleton template, covering both cart drawer (aside) and cart page contexts. Why: The skeleton template's cart functionality lacked E2E test coverage for core user interactions like adding items, changing quantities, and removing items. These tests ensure cart behavior works correctly across both the aside drawer and dedicated cart page. What's included: - 17 tests organized by behavior (adding, quantity, removing, totals, edge cases) - StorefrontPage fixture extended with 14 cart helper methods - e2e/CLAUDE.md guidelines for test isolation and selector strategy Key design decisions: - Cookie clearing for test isolation (cart state stored in cookies) - expect.poll() for waiting on actual state changes, not just UI re-enablement - :visible pseudo-selector to avoid matching hidden drawer elements on cart page - Role-based selectors for accessibility compliance (getByRole with aria-labels) Tests passed 51/51 runs (17 tests × 3 repetitions) with no flakiness.
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
fredericoo
reviewed
Jan 28, 2026
Contributor
There was a problem hiding this comment.
can we stick this under cart? line items can be a describe block in the cart spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
The skeleton template's cart functionality lacked E2E test coverage for core user interactions. Without these tests, regressions in cart behavior (adding items, changing quantities, removing items) could go undetected across both the cart drawer and cart page contexts.
Related to ongoing E2E test expansion effort.
WHAT is this pull request doing?
Adds comprehensive E2E tests for cart line item behavior with 17 tests organized by user behavior:
Key implementation details:
expect.poll()for waiting on actual state changes:visiblepseudo-selector to avoid matching hidden drawer elementsNew file:
e2e/CLAUDE.mdwith testing guidelines for future contributors.HOW to test your changes?
Expected: All 17 tests pass (51/51 with 3 repetitions).
Checklist