feat(e2e): add gift card E2E test suite #3418
Open
+621
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
kdaviduik
force-pushed
the
kd-set-up-secrets-for-e2e
branch
from
4e260be to
d6bf802
Compare
kdaviduik
force-pushed
the
kd-gift-cards-e2e
branch
from
0543a30 to
a47eef5
Compare
kdaviduik
commented
Jan 27, 2026
Comment on lines
+952
to
+956
| /** | ||
| * Get the amount for a specific applied gift card. | ||
| * The DOM structure has the amount as a sibling of the code element within the same parent. | ||
| */ | ||
| private async getAppliedCardAmount(lastCharacters: string): Promise<string> { |
Contributor
Author
There was a problem hiding this comment.
I wouldn't be opposed to not testing this (eg: this seems like logic that's fairly brittle). My vote would be to keep it in for now but if it starts causing us issues in the future we can axe it
kdaviduik
force-pushed
the
kd-gift-cards-e2e
branch
3 times, most recently
from
1bbaade to
e143db3
Compare
5 tasks
fredericoo
reviewed
Jan 27, 2026
fredericoo
reviewed
Jan 27, 2026
fredericoo
reviewed
Jan 27, 2026
fredericoo
reviewed
Jan 27, 2026
Contributor
fredericoo
left a comment
fredericoo
left a comment
There was a problem hiding this comment.
we spotted a bug!
- add a VALID gift card
- remove it
- add a gift card DIFFERENT than the first one
- the first one will be resurrected 😇
the reason is probably related to us storing the inputs of the card form as a ref (CartSummary.tsx line 113)
fredericoo
reviewed
Jan 27, 2026
kdaviduik
force-pushed
the
kd-gift-cards-e2e
branch
from
e143db3 to
5734913
Compare
kdaviduik
force-pushed
the
kd-set-up-secrets-for-e2e
branch
from
d6bf802 to
4f0b3ea
Compare
kdaviduik
force-pushed
the
kd-gift-cards-e2e
branch
2 times, most recently
from
2e3c7b2 to
d7e2cc3
Compare
Contributor
Author
|
@fredericoo this PR should fix the gift card resurrection bug (where a deleted gift card could come back). I haven't had a chance to manually tophat yet, so that's why it's still a draft. But if you get a chance feel free to un-draft the PR |
fredericoo
approved these changes
Jan 29, 2026
Add infrastructure for securely loading test secrets from secrets.ejson
using EJSON encryption. This enables E2E tests to use real gift card codes
without hardcoding them in test files.
Example usage in an E2E test file:
```typescript
import {getRequiredSecret} from '../../fixtures/test-secrets';
const GIFT_CARD_CODE_1 = getRequiredSecret('gift_card_code_1');
const GIFT_CARD_CODE_2 = getRequiredSecret('gift_card_code_2');
```
How it works:
- Secrets stored encrypted in secrets.ejson under `e2e-testing` section
- Local dev: Uses ejson keydir at /opt/ejson/keys (standard convention)
- CI: Uses EJSON_PRIVATE_KEY env var passed via --key-from-stdin
- Single code path for both environments
Security considerations:
- Uses execFileSync (not execSync) to prevent shell injection
- Private key passed via stdin, never on command line or disk
- Secrets decrypted in-memory, never written to files
Add comprehensive E2E tests for gift card functionality in the Hydrogen skeleton template. This validates that gift cards can be applied, removed, and persisted across page reloads. Tests use the hydrogenPreviewStorefront store with encrypted gift card codes stored in secrets.ejson. The test suite includes: - Core functionality: apply/remove single and multiple gift cards, persistence across reload - Edge cases: duplicate codes, case-insensitivity, invalid codes, empty/whitespace handling Implementation follows deep module pattern with gift card helpers in StorefrontPage fixture. Uses 3-phase waiting (response → input clear → element visible) to prevent race conditions.
fredericoo
force-pushed
the
kd-gift-cards-e2e
branch
from
d7e2cc3 to
ba7a43d
Compare
Contributor
|
i have rebased this PR so we get GiftCardCodesAdd back |
kdaviduik
force-pushed
the
kd-set-up-secrets-for-e2e
branch
from
4f0b3ea to
8f952fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Closes https://github.com/Shopify/developer-tools-team/issues/979.
The skeleton template includes gift card functionality, but we had no automated tests verifying it works correctly. This adds E2E coverage to catch regressions in gift card apply/remove flows.
WHAT is this pull request doing?
Adds a comprehensive E2E test suite for gift card functionality with 10 test cases:
Core Functionality (5 tests):
Edge Cases (5 tests):
HOW to test your changes?
These are automatically run as part of CI. But you can also manually test with:
npx playwright test e2e/skeleton/giftCards.spec.ts --project=skeletonChecklist