-
Notifications
You must be signed in to change notification settings - Fork 380
chore(cart): remove redundant gift card code deduplication #3402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
59c479d to
254bc3e
Compare
e42e3e3 to
581d680
Compare
254bc3e to
f0d7fc3
Compare
581d680 to
0526f35
Compare
|
We detected some changes in |
packages/hydrogen/src/cart/queries/cartGiftCardCodeUpdateDefault.ts
Outdated
Show resolved
Hide resolved
0526f35 to
612ebee
Compare
cbf41a0 to
c24fd25
Compare
612ebee to
1d43ad3
Compare
c24fd25 to
9268ed7
Compare
68a4ee6 to
faecd2a
Compare
9268ed7 to
79d73b7
Compare
faecd2a to
ebd7116
Compare
79d73b7 to
403c1f5
Compare
Removes client-side duplicate filtering from `cartGiftCardCodesUpdate`. ## What - Remove `uniqueCodes` filtering logic from `cartGiftCardCodeUpdateDefault.ts` ## Why E2E testing confirmed the Storefront API handles duplicate gift card codes gracefully (idempotent behavior). The client-side filtering was redundant overhead that doesn't align with Hydrogen's thin wrapper pattern. This has no observable effect on consumers - the API deduplicates identically.
ebd7116 to
cb68e36
Compare

WHY are these changes introduced?
E2E testing confirmed the Storefront API handles duplicate gift card codes gracefully (idempotent behavior). The client-side filtering in
cartGiftCardCodesUpdatewas redundant overhead that doesn't align with Hydrogen's thin wrapper pattern.WHAT is this pull request doing?
Removes the
uniqueCodesfiltering logic fromcartGiftCardCodeUpdateDefault.ts.Behavior change: None. The API deduplicates identically to the client-side logic that was removed.
HOW to test your changes?
This is an internal cleanup with no observable behavior change. The existing tests verify the mutation still works correctly.
Checklist