Rename CACHE_DIRECTORY to .erb_lint_cache.

[joshuapinter]

From .erb-lint-cache.

This is to align with the general renaming and standardization from erb-lint and erblint to erb_lint.

Fixes #379.

[etiennebarrie]

Do you think we need to do anything about the migration or just document this in the release notes when releasing the new version?

[joshuapinter]

Good question. Personally, I just rolled this into our app and it just had to rebuild the cache fresh the first time and I just had to update the .gitignore and some other references to it.

I wouldn't consider this a breaking change or anything. Since we're not at v1 yet I think it's fair just to put it into the Release Notes / CHANGELOG.md, which I forgot to do btw.

Let me know what you think and I can update the PR.

[etiennebarrie]

I wouldn't consider this a breaking change or anything. Since we're not at v1 yet I think it's fair just to put it into the Release Notes / CHANGELOG.md, which I forgot to do btw.

Yeah I think it's good enough to have a good message. We don't have a changelog file but we use GitHub releases which show up in Dependabot PRs for example.

Thanks for your contribution!

[joshuapinter]

👍 Awesome, thanks for the quick turnaround.

Btw, I have another PR (#300) that is critical for anybody using the cache, which breaks it when there are configuration or Gemfile changes to avoid false negatives, etc. If there's anything you can do to give it some attention, it would be valuable. We're using it in Production in our fork and it's been solid for us.

Thanks again.

[etiennebarrie]

Yes, I saw. I liked #373 quite a bit better, we just need some specs.

[joshuapinter]

Yep, I agree. That's much more clever. :) Thanks.