Add --prevent-empty-failure flag #188
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag aims to prevent a failure throw when there are no files that match either the given glob or the default one, this can be helpful in some cases such as some pre-commit hooks that run against the diff-ed files, for example: Commiting files that do not include any erb extension, then, running linters as part of a pre-commit check, including (as an example) rubocop, reek, stylelint, fasterer, and erb-lint, would throw an error since there are no files to run erb-lint against, preventing the user to properly create a commit.
hc0503
approved these changes
Nov 9, 2020
lhmzhou
approved these changes
Aug 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag aims to prevent a failure throw when there are no files that
match either the given glob or the default one, this can be helpful in
some cases such as some pre-commit hooks that run against the diff-ed
files, for example:
Commiting files that do not include any erb extension, then, running
linters as part of a pre-commit check, including (as an example) rubocop,
reek, stylelint, fasterer, and erb-lint, would throw an error since there are no
files to run erb-lint against, preventing the user to properly create a
commit.
Note: The flag name might not be the most suitable, open to discuss a better one 😄